Skip to content

add libvirt tag to libvirt-ci Dockerfile #961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Dec 21, 2018
Merged

add libvirt tag to libvirt-ci Dockerfile #961

openshift-merge-robot merged 1 commit into from
Dec 21, 2018

Conversation

@sallyom
Copy link
Contributor

@sallyom sallyom commented Dec 20, 2018 •
edited
Loading

@wking ptal, working on libvirt ci job, found I need to build with libvirt tag

With this: openshift/release#2410 we have a working ci setup for libvirt

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 20, 2018
@sallyom sallyom changed the title add LIBVIRT tag to libvirt-ci Dockerfile add libvirt tag to libvirt-ci Dockerfile Dec 20, 2018
@sallyom
Copy link
Contributor Author

sallyom commented Dec 20, 2018

/test e2e-aws

@sallyom
Copy link
Contributor Author

sallyom commented Dec 20, 2018

Note: this will require an update when/if this lands: #955 (comment)

@sallyom sallyom mentioned this pull request Dec 20, 2018
Merged
@wking
Copy link
Member

wking commented Dec 20, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 20, 2018
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 20, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sallyom, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 20, 2018
@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 21, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 21, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 21, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 21, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 21, 2018

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 4ea77b8 into openshift:master Dec 21, 2018
@wking wking mentioned this pull request Dec 21, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crawford crawford Awaiting requested review from crawford

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@wking wking

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sallyom @wking @openshift-ci-robot @openshift-bot @openshift-merge-robot