Skip to content

CNTRLPLANE-179: apiserver library go bump #2285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 1 commit into from
May 20, 2025
Merged

CNTRLPLANE-179: apiserver library go bump #2285

openshift-merge-bot merged 1 commit into from
May 20, 2025

Conversation

@ibihim
Copy link

@ibihim ibihim commented May 6, 2025 •
edited
Loading

What

Bumps apiserver-library-go

Why

  • Contains a new annotation that highlights the origin of the SCC assigned: user / service-account.
  • Some small refactoring for improved readability.

@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label May 6, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 6, 2025

@ibihim: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@ibihim ibihim changed the title CNTRLPLANE-179 apiserver library go bump [WIP] CNTRLPLANE-179 apiserver library go bump May 6, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 6, 2025
@openshift-ci openshift-ci bot requested review from bertinatto and deads2k May 6, 2025 09:52
@openshift-ci openshift-ci bot added the vendor-update Touching vendor dir or related files label May 6, 2025
@ibihim ibihim force-pushed the ibihim/2025-05-06_CNTRLPLANE-179-apiserver-library-go-bump branch from 9a06878 to 694cba2 Compare May 6, 2025 12:11
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 6, 2025

@ibihim: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@ibihim ibihim force-pushed the ibihim/2025-05-06_CNTRLPLANE-179-apiserver-library-go-bump branch from 694cba2 to 13836dc Compare May 6, 2025 12:12
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 6, 2025

@ibihim: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@ibihim
Copy link
Author

ibihim commented May 7, 2025

/retest-required

4 similar comments
@ibihim
Copy link
Author

ibihim commented May 7, 2025

/retest-required

@ibihim
Copy link
Author

ibihim commented May 8, 2025

/retest-required

@ibihim
Copy link
Author

ibihim commented May 12, 2025

/retest-required

@ibihim
Copy link
Author

ibihim commented May 12, 2025

/retest-required

@ibihim ibihim changed the title [WIP] CNTRLPLANE-179 apiserver library go bump CNTRLPLANE-179 apiserver library go bump May 13, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 13, 2025
@ibihim
Copy link
Author

ibihim commented May 13, 2025

/test okd-scos-e2e-aws-ovn

1 similar comment
@ibihim
Copy link
Author

ibihim commented May 15, 2025

/test okd-scos-e2e-aws-ovn

@ibihim ibihim mentioned this pull request May 15, 2025
Open
bertinatto
bertinatto reviewed May 16, 2025
View reviewed changes
Copy link
Member

@bertinatto bertinatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/remove-label backports/unvalidated-commits
/label backports/validated-commits

@openshift-ci openshift-ci bot added backports/validated-commits Indicates that all commits come to merged upstream PRs. and removed backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. labels May 16, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 16, 2025
@openshift-ci
Copy link

openshift-ci bot commented May 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, ibihim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 16, 2025
@ibihim
Copy link
Author

ibihim commented May 19, 2025

/jira refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 19, 2025

@ibihim: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ibihim ibihim changed the title CNTRLPLANE-179 apiserver library go bump CNTRLPLANE-179: apiserver library go bump May 19, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 19, 2025 •
edited by openshift-ci bot
Loading

@ibihim: This pull request references CNTRLPLANE-179 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

Details

In response to this:

What

Bumps apiserver-library-go

Why

  • Contains a new annotation that highlights the origin of the SCC assigned: user / service-account.
  • Some small refactoring for improved readability.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 19, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 19, 2025

/retest-required

Remaining retests: 0 against base HEAD 633fd3c and 2 for PR HEAD 13836dc in total

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 19, 2025

/retest-required

Remaining retests: 0 against base HEAD 69dc9ae and 1 for PR HEAD 13836dc in total

@openshift-ci
Copy link

openshift-ci bot commented May 20, 2025

@ibihim: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@bertinatto
Copy link
Member

bertinatto commented May 20, 2025

/payload-job periodic-ci-openshift-release-master-nightly-4.20-e2e-metal-ipi-ovn-bm
/payload-job periodic-ci-openshift-release-master-nightly-4.20-e2e-metal-ipi-ovn-ipv6

Just using this PR to check if the above jobs are working at all. Please ignore.

@openshift-ci
Copy link

openshift-ci bot commented May 20, 2025

@bertinatto: trigger 2 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.20-e2e-metal-ipi-ovn-bm
  • periodic-ci-openshift-release-master-nightly-4.20-e2e-metal-ipi-ovn-ipv6

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/145c20a0-3516-11f0-86a1-0afa63326678-0

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 20, 2025

/retest-required

Remaining retests: 0 against base HEAD 69dc9ae and 2 for PR HEAD 13836dc in total

@openshift-merge-bot openshift-merge-bot bot merged commit 10466b2 into openshift:master May 20, 2025
22 checks passed
@openshift-bot
Copy link

openshift-bot commented May 20, 2025

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-hyperkube
This PR has been included in build openshift-enterprise-hyperkube-container-v4.20.0-202505200057.p0.g10466b2.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link

openshift-bot commented May 20, 2025

[ART PR BUILD NOTIFIER]

Distgit: kube-proxy
This PR has been included in build kube-proxy-container-v4.20.0-202505200057.p0.g10466b2.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link

openshift-bot commented May 20, 2025

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-pod
This PR has been included in build openshift-enterprise-pod-container-v4.20.0-202505200057.p0.g10466b2.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link

openshift-bot commented May 20, 2025

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-kube-apiserver-artifacts
This PR has been included in build ose-installer-kube-apiserver-artifacts-container-v4.20.0-202505200057.p0.g10466b2.assembly.stream.el9.
All builds following this will include this PR.

@vrutkovs vrutkovs mentioned this pull request Jul 2, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bertinatto bertinatto bertinatto left review comments

@deads2k deads2k Awaiting requested review from deads2k

Assignees

@bertinatto bertinatto

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backports/validated-commits Indicates that all commits come to merged upstream PRs. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. vendor-update Touching vendor dir or related files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ibihim @openshift-ci-robot @bertinatto @openshift-bot