Skip to content

Bug 2110501: Revert "Bug 2101880: operator NS manifest: Set empty openshift.io/run-level" #1045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Jul 26, 2022
Merged

Bug 2110501: Revert "Bug 2101880: operator NS manifest: Set empty openshift.io/run-level" #1045

openshift-merge-robot merged 1 commit into from
Jul 26, 2022

Conversation

@bparees
Copy link
Contributor

@bparees bparees commented Jul 25, 2022

Reverts #1031

@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jul 25, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 25, 2022

@bparees: This pull request references Bugzilla bug 2101880, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is VERIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Revert "Bug 2101880: operator NS manifest: Set empty openshift.io/run-level"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JoelSpeed
Copy link
Contributor

JoelSpeed commented Jul 25, 2022

/lgtm
/approve

@bparees bparees changed the title Revert "Bug 2101880: operator NS manifest: Set empty openshift.io/run-level" Bug 2110501: Revert "Bug 2101880: operator NS manifest: Set empty openshift.io/run-level" Jul 25, 2022
@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jul 25, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 25, 2022

@bparees: This pull request references Bugzilla bug 2110501, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.12.0) matches configured target release for branch (4.12.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

Details

In response to this:

Bug 2110501: Revert "Bug 2101880: operator NS manifest: Set empty openshift.io/run-level"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from sunzhaohua2 July 25, 2022 14:01
@JoelSpeed
Copy link
Contributor

JoelSpeed commented Jul 25, 2022

/hold until @bparees is happy for this to merge

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 25, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 25, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 25, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 25, 2022
@bparees
Copy link
Contributor Author

bparees commented Jul 25, 2022

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 25, 2022
@wking
Copy link
Member

wking commented Jul 25, 2022

/retest required

@wking
Copy link
Member

wking commented Jul 25, 2022

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 25, 2022

@wking: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /test e2e-aws
  • /test e2e-aws-operator
  • /test e2e-aws-upgrade
  • /test e2e-vsphere-serial
  • /test goimports
  • /test golint
  • /test govet
  • /test images
  • /test unit
  • /test verify-crds-sync
  • /test yaml-lint

The following commands are available to trigger optional jobs:

  • /test e2e-aws-disruptive
  • /test e2e-aws-operator-tech-preview
  • /test e2e-azure
  • /test e2e-azure-operator
  • /test e2e-gcp
  • /test e2e-gcp-operator
  • /test e2e-libvirt
  • /test e2e-metal-ipi
  • /test e2e-metal-ipi-ovn-dualstack
  • /test e2e-metal-ipi-ovn-ipv6
  • /test e2e-metal-ipi-upgrade
  • /test e2e-metal-ipi-virtualmedia
  • /test e2e-openstack
  • /test e2e-vsphere
  • /test e2e-vsphere-operator
  • /test e2e-vsphere-upgrade

Use /test all to run all jobs.

Details

In response to this:

/retest required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bparees
Copy link
Contributor Author

bparees commented Jul 25, 2022

/retest required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 25, 2022

@bparees: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /test e2e-aws
  • /test e2e-aws-operator
  • /test e2e-aws-upgrade
  • /test e2e-vsphere-serial
  • /test goimports
  • /test golint
  • /test govet
  • /test images
  • /test unit
  • /test verify-crds-sync
  • /test yaml-lint

The following commands are available to trigger optional jobs:

  • /test e2e-aws-disruptive
  • /test e2e-aws-operator-tech-preview
  • /test e2e-azure
  • /test e2e-azure-operator
  • /test e2e-gcp
  • /test e2e-gcp-operator
  • /test e2e-libvirt
  • /test e2e-metal-ipi
  • /test e2e-metal-ipi-ovn-dualstack
  • /test e2e-metal-ipi-ovn-ipv6
  • /test e2e-metal-ipi-upgrade
  • /test e2e-metal-ipi-virtualmedia
  • /test e2e-openstack
  • /test e2e-vsphere
  • /test e2e-vsphere-operator
  • /test e2e-vsphere-upgrade

Use /test all to run all jobs.

Details

In response to this:

/retest required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 25, 2022

/retest-required

Remaining retests: 2 against base HEAD d215d31 and 8 for PR HEAD 66dc5e1 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 26, 2022

@bparees: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure-operator 66dc5e1 link false /test e2e-azure-operator
ci/prow/e2e-metal-ipi-virtualmedia 66dc5e1 link false /test e2e-metal-ipi-virtualmedia
ci/prow/e2e-vsphere 66dc5e1 link false /test e2e-vsphere
ci/prow/e2e-openstack 66dc5e1 link false /test e2e-openstack
ci/prow/e2e-metal-ipi-ovn-ipv6 66dc5e1 link false /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-aws-disruptive 66dc5e1 link false /test e2e-aws-disruptive
ci/prow/e2e-libvirt 66dc5e1 link false /test e2e-libvirt
ci/prow/e2e-metal-ipi-ovn-dualstack 66dc5e1 link false /test e2e-metal-ipi-ovn-dualstack

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit fef93d7 into master Jul 26, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 26, 2022

@bparees: All pull requests linked via external trackers have merged:

Bugzilla bug 2110501 has been moved to the MODIFIED state.

Details

In response to this:

Bug 2110501: Revert "Bug 2101880: operator NS manifest: Set empty openshift.io/run-level"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexander-demicev alexander-demicev Awaiting requested review from alexander-demicev

@elmiko elmiko Awaiting requested review from elmiko

@sunzhaohua2 sunzhaohua2 Awaiting requested review from sunzhaohua2

Assignees

@JoelSpeed JoelSpeed

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bparees @JoelSpeed @wking @openshift-ci-robot @openshift-merge-robot