Skip to content

Bug 2111972: operator NS manifest: Set empty openshift.io/run-level #1053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Aug 25, 2022
Merged

Bug 2111972: operator NS manifest: Set empty openshift.io/run-level #1053

openshift-merge-robot merged 1 commit into from
Aug 25, 2022

Conversation

@JoelSpeed
Copy link
Contributor

@JoelSpeed JoelSpeed commented Aug 8, 2022

This reverts commit 401fe30.

Reintroducing #1031 since it was reverted in #1044.

This should no longer cause any issues since openshift/cluster-version-operator#804 was merged to solve the issue presented by removing the run-level annotation

@openshift-ci openshift-ci bot added bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Aug 8, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 8, 2022

@JoelSpeed: This pull request references Bugzilla bug 2111972, which is invalid:

  • expected the bug to target the "4.12.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 2111972: operator NS manifest: Set empty openshift.io/run-level

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lobziik
Copy link
Contributor

lobziik commented Aug 8, 2022

/approve

@JoelSpeed
Copy link
Contributor Author

JoelSpeed commented Aug 8, 2022

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Aug 8, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 8, 2022

@JoelSpeed: This pull request references Bugzilla bug 2111972, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.12.0) matches configured target release for branch (4.12.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 8, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lobziik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 8, 2022
@elmiko
Copy link
Contributor

elmiko commented Aug 18, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 18, 2022
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 18, 2022

/retest-required

Remaining retests: 2 against base HEAD 1c83be8 and 8 for PR HEAD 9c2b8f6 in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 18, 2022

/retest-required

Remaining retests: 1 against base HEAD 1c83be8 and 7 for PR HEAD 9c2b8f6 in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 18, 2022

/retest-required

Remaining retests: 0 against base HEAD 1c83be8 and 6 for PR HEAD 9c2b8f6 in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 22, 2022

/retest-required

Remaining retests: 2 against base HEAD f522fc0 and 5 for PR HEAD 9c2b8f6 in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 22, 2022

/retest-required

Remaining retests: 1 against base HEAD f522fc0 and 4 for PR HEAD 9c2b8f6 in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 22, 2022

/retest-required

Remaining retests: 0 against base HEAD f522fc0 and 3 for PR HEAD 9c2b8f6 in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 23, 2022

/retest-required

Remaining retests: 2 against base HEAD d341daa and 2 for PR HEAD 9c2b8f6 in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 23, 2022

/retest-required

Remaining retests: 1 against base HEAD d341daa and 1 for PR HEAD 9c2b8f6 in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 23, 2022

/retest-required

Remaining retests: 0 against base HEAD d341daa and 0 for PR HEAD 9c2b8f6 in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 23, 2022

/hold

Revision 9c2b8f6 was retested 9 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 23, 2022
@JoelSpeed
Copy link
Contributor Author

JoelSpeed commented Aug 24, 2022

/hold cancel
/retest-required

Looking at the results they seem to be flakes that we see commonly, not concerned about a major regression

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 24, 2022
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 24, 2022

/retest-required

Remaining retests: 2 against base HEAD d341daa and 8 for PR HEAD 9c2b8f6 in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 24, 2022

/retest-required

Remaining retests: 1 against base HEAD d341daa and 7 for PR HEAD 9c2b8f6 in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 24, 2022

/retest-required

Remaining retests: 0 against base HEAD d341daa and 6 for PR HEAD 9c2b8f6 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 24, 2022 •
edited
Loading

@JoelSpeed: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-ovn-dualstack 9c2b8f6 link false /test e2e-metal-ipi-ovn-dualstack
ci/prow/e2e-libvirt 9c2b8f6 link false /test e2e-libvirt
ci/prow/e2e-vsphere-operator 9c2b8f6 link false /test e2e-vsphere-operator
ci/prow/e2e-vsphere 9c2b8f6 link false /test e2e-vsphere
ci/prow/e2e-vsphere-upgrade 9c2b8f6 link false /test e2e-vsphere-upgrade
ci/prow/e2e-aws-disruptive 9c2b8f6 link false /test e2e-aws-disruptive
ci/prow/e2e-azure-operator 9c2b8f6 link false /test e2e-azure-operator
ci/prow/e2e-metal-ipi-upgrade 9c2b8f6 link false /test e2e-metal-ipi-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JoelSpeed
Copy link
Contributor Author

JoelSpeed commented Aug 25, 2022

/override ci/prow/e2e-vsphere-serial

I'm pretty happy this isn't breaking anything as the majority of the test suites have passed. The vsphere tests are known to be flaky

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 25, 2022

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/e2e-vsphere-serial

Details

In response to this:

/override ci/prow/e2e-vsphere-serial

I'm pretty happy this isn't breaking anything as the majority of the test suites have passed. The vsphere tests are known to be flaky

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 061bfe9 into openshift:master Aug 25, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 25, 2022

@JoelSpeed: All pull requests linked via external trackers have merged:

Bugzilla bug 2111972 has been moved to the MODIFIED state.

Details

In response to this:

Bug 2111972: operator NS manifest: Set empty openshift.io/run-level

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JoelSpeed JoelSpeed deleted the empty-run-level branch August 25, 2022 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sunzhaohua2 sunzhaohua2 Awaiting requested review from sunzhaohua2

@alexander-demicev alexander-demicev Awaiting requested review from alexander-demicev

@lobziik lobziik Awaiting requested review from lobziik

Assignees

@elmiko elmiko

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@JoelSpeed @lobziik @elmiko @openshift-ci-robot @openshift-merge-robot