Skip to content

Conversation

@runcom
Copy link
Member

@runcom runcom commented Jun 18, 2020

This was merged but caused CNO CI issues on upgrades so we reverted. Bringing this up for @mccv1r0 @squeed @dcbw for further testing before the green light on this.

Signed-off-by: Antonio Murdaca [email protected]

@runcom runcom added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 18, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 18, 2020
@trozet
Copy link
Contributor

trozet commented Jun 23, 2020

CNO patch is now merged

/retest

@trozet
Copy link
Contributor

trozet commented Jun 24, 2020

/retest

@squeed
Copy link
Contributor

squeed commented Jun 24, 2020

OVN and openshift-sdn came up fine! This looks good. The test failure is the annoying ovn deadlock; that should be fixed soon.
for what it's worth,
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 24, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: runcom, squeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@runcom
Copy link
Member Author

runcom commented Jun 24, 2020

OVN and openshift-sdn came up fine! This looks good. The test failure is the annoying ovn deadlock; that should be fixed soon.
for what it's worth,
/lgtm

given the confidence in this by the CNO team, I'm unholding this :) thanks everybody for the testing

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 24, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@squeed
Copy link
Contributor

squeed commented Jun 24, 2020

/test e2e-aws

@squeed
Copy link
Contributor

squeed commented Jun 24, 2020

/test e2e-aws
(something seems wrong with the CI cluster)

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@squeed
Copy link
Contributor

squeed commented Jun 24, 2020

/test e2e-aws

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@squeed
Copy link
Contributor

squeed commented Jun 24, 2020

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit f0f9144 into openshift:master Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants