Skip to content

Conversation

@wking
Copy link
Member

@wking wking commented Dec 17, 2022

The broken URIs were originally from 2c44c12 (#2802)

…ineConfigControllerPausedPoolKubeletCA runbook URIs

The broken URIs were originally from 2c44c12 (Add plumbing for mcc
metrics handler, 2022-02-25, openshift#2802)
@openshift-ci-robot openshift-ci-robot added jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Dec 17, 2022
@openshift-ci-robot
Copy link
Contributor

@wking: This pull request references Jira Issue OCPBUGS-5001, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.0) matches configured target version for branch (4.13.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @rioliu-rh

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

The broken URIs were originally from 2c44c12 (#2802)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jkyros
Copy link
Member

jkyros commented Dec 17, 2022

Yup. Whoops. Thanks Trevor.
/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 17, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 17, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jkyros, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 17, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 17, 2022

@wking: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-alibabacloud 84470db link false /test e2e-alibabacloud
ci/prow/e2e-hypershift 84470db link false /test e2e-hypershift

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 2e3e16b into openshift:master Dec 17, 2022
@openshift-ci-robot
Copy link
Contributor

@wking: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-5001 has been moved to the MODIFIED state.

Details

In response to this:

The broken URIs were originally from 2c44c12 (#2802)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking wking deleted the fix-runbook-uris branch December 18, 2022 16:26
@jkyros
Copy link
Member

jkyros commented Dec 19, 2022

/cherry-pick release-4.12

@openshift-cherrypick-robot

@jkyros: #3462 failed to apply on top of branch "release-4.12":

Applying: install/0000_90_machine-config-operator_01_prometheus-rules: Fix MachineConfigControllerPausedPoolKubeletCA runbook URIs
Using index info to reconstruct a base tree...
M	install/0000_90_machine-config-operator_01_prometheus-rules.yaml
Falling back to patching base and 3-way merge...
Auto-merging install/0000_90_machine-config-operator_01_prometheus-rules.yaml
CONFLICT (content): Merge conflict in install/0000_90_machine-config-operator_01_prometheus-rules.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 install/0000_90_machine-config-operator_01_prometheus-rules: Fix MachineConfigControllerPausedPoolKubeletCA runbook URIs
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherry-pick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants