MCO-1961: OSImageStream follow up #5458
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@pablintino: This pull request references MCO-1961 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
approved
|
/verified by @pablintino |
openshift-ci-robot
added
the
verified
|
@pablintino: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
pablintino
force-pushed
the
osimagestream-followup-1
branch
from
f1d8e1d to
0d269f9
Compare
openshift-ci-robot
removed
the
verified
openshift-merge-robot
added
the
needs-rebase
pablintino
force-pushed
the
osimagestream-followup-1
branch
from
0d269f9 to
4b24805
Compare
openshift-merge-robot
removed
the
needs-rebase
|
@pablintino: This pull request references MCO-1961 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@pablintino: This pull request references MCO-1961 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
pablintino
force-pushed
the
osimagestream-followup-1
branch
2 times, most recently
from
d4f92d7 to
7cf1c7f
Compare
This change corrects a few things: - Comments from the original content like ensuring helpers_test.go test data is created once per test case or making GetOSImageStreamSetByName return a k8s NotFound error in case the requested stream doesn't exist. - Bugfix to ensure that URL based sources don't pass empty ImageDatas to the GroupOSContainerImageMetadataToStream function in case one or both images don't have enough labels to determine the stream. The same patch is applied to the ImageStream source. - Ensure that GroupOSContainerImageMetadataToStream never returns partial OSImageStreamSets with only one of the URLs filled.
pablintino
force-pushed
the
osimagestream-followup-1
branch
from
7cf1c7f to
019e91e
Compare
|
/test e2e-aws-ovn |
| // How can a stream end here? | ||
| // - An ImageStream with only one of the images tagged | ||
| // - A proper built ImageStream but one of the images is lacking the stream labels | ||
| // - A URL set with only one image having the labels |
isabella-janssen
left a comment
isabella-janssen
left a comment
There was a problem hiding this comment.
/lgtm
Changes look clear & updated units are still passing.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: isabella-janssen, pablintino The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/verified by @pablintino |
openshift-ci-robot
added
the
verified
|
@pablintino: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/test e2e-gcp-op-2of2 |
|
/label acknowledge-critical-fixes-only |
openshift-ci
bot
added
the
acknowledge-critical-fixes-only
|
/override ci/prow/e2e-gcp-op-2of2 Should both be unrelated |
|
@yuqi-zhang: Overrode contexts on behalf of yuqi-zhang: ci/prow/e2e-aws-ovn-upgrade, ci/prow/e2e-gcp-op-2of2 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@pablintino: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-merge-bot
bot
merged commit 5051cce
into
openshift:main
5 participants
- What I did
Minor improvement to:
pkg/controller/osimagestream/helpers_test.gotesting data is created once per test case and not shared between test cases.GetOSImageStreamSetByNamefunction return a k8s NotFound error in case the requested OSImageStreamSet does not exist.- How to verify it
Unit tests are enough to test the functionality.
- Description for the changelog
Improved OSImageStreamSet retrieval error handling and fixed bugs with URL-based image source metadata grouping