OCPBUGS-56717: enable nodeip-configuration for platform external

[emy]

- What I did
Add a condition to the nodeip-configuration.service template that should enable nodeip-configuration.service when PlatformStatus.Type is set to External

- How to verify it
According to Ross the test upi-conf-vsphere-platform-external exists.

- Description for the changelog

Enable nodeip-configuration.service when PlatformStatus.Type is External.

[openshift-ci-robot]

@emy: This pull request references Jira Issue OCPBUGS-56717, which is invalid:

• expected the bug to target the "4.21.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

- What I did
Add a condition to the nodeip-configuration.service template that should enable nodeip-configuration.service when PlatformStatus.Type is set to External

- How to verify it
According to Ross the test upi-conf-vsphere-platform-external exists.

- Description for the changelog

Enable nodeip-configuration.service when PlatformStatus.Type is External.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[rbbratta]

/verified by @rbbratta

[openshift-ci-robot]

@rbbratta: This PR has been marked as verified by @rbbratta.

Details

In response to this:

/verified by @rbbratta

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[rbbratta]

/jira refresh

[openshift-ci-robot]

@rbbratta: This pull request references Jira Issue OCPBUGS-56717, which is invalid:

• expected the bug to target either version "4.22." or "openshift-4.22.", but it targets "4.21.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[rbbratta]

/jira refresh

[openshift-ci-robot]

@rbbratta: This pull request references Jira Issue OCPBUGS-56717, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.22.0) matches configured target version for branch (4.22.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @rbbratta

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[mkowalski]

/lgtm
/approve

[cybertron]

/retest-required
/assign @pablintino

[pablintino]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: emy, mkowalski, pablintino

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [pablintino]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@emy: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/bootstrap-unit	7c5ee03	link	false	/test bootstrap-unit

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[isabella-janssen]

/retest-required

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD c8a6c4f and 2 for PR HEAD 7c5ee03 in total

[openshift-ci-robot]

@emy: Jira Issue Verification Checks: Jira Issue OCPBUGS-56717
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-56717 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

- What I did
Add a condition to the nodeip-configuration.service template that should enable nodeip-configuration.service when PlatformStatus.Type is set to External

- How to verify it
According to Ross the test upi-conf-vsphere-platform-external exists.

- Description for the changelog

Enable nodeip-configuration.service when PlatformStatus.Type is External.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.