"OCPBUGS-74101: Fixes the issue in the test TestKubeletConfigMaxPods when AutoNodeSizing is enabled by default"

[ngopalak-redhat]

- What I did
Reported by @djoshy : https://redhat-internal.slack.com/archives/CK1AE4ZCK/p1768319412897509

The TestKubeletConfigMaxPods test has been failing intermittently since PR #5491 merged. The failure occurs at the allocatable memory assertion:

  kubeletcfg_test.go:172:
      Error:      	Should not be: 13435936768
      Test:       	TestKubeletConfigMaxPods
      Messages:   	value of the allocatable should have changed

PR #5491 changed the default behavior for worker nodes:

Before PR #5491:

• NODE_SIZING_ENABLED=false (autosizing disabled by default)
• System reserved memory: 1GB (static)

After PR #5491:

• NODE_SIZING_ENABLED=true (autosizing enabled by default for non-Hypershift clusters)
• System reserved memory: ~2GB (dynamically calculated)

The test at kubeletcfg_test.go:165-173 made an invalid assumption:

1. It assumed nodes start with autosizing disabled
2. It expected applying AutoSizingReserved: true to enable autosizing for the first time
3. It expected this state change to alter allocatable memory

What actually happens now:

1. Worker nodes already have autosizing enabled by default
2. Test applies AutoSizingReserved: true → no state change (already enabled)
3. Allocatable memory stays the same → assertion fails ❌

Solution
I removed the allocatable memory assertion

Related: #5491

- How to verify it

- Description for the changelog

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci-robot]

@ngopalak-redhat: This pull request explicitly references no jira issue.

Details

In response to this:

- What I did
The TestKubeletConfigMaxPods test has been failing intermittently since PR #5491 merged. The failure occurs at the allocatable memory assertion:

 kubeletcfg_test.go:172:
     Error:      	Should not be: 13435936768
     Test:       	TestKubeletConfigMaxPods
     Messages:   	value of the allocatable should have changed

PR #5491 changed the default behavior for worker nodes:

Before PR #5491:

• NODE_SIZING_ENABLED=false (autosizing disabled by default)
• System reserved memory: 1GB (static)

After PR #5491:

• NODE_SIZING_ENABLED=true (autosizing enabled by default for non-Hypershift clusters)
• System reserved memory: ~2GB (dynamically calculated)

The test at kubeletcfg_test.go:165-173 made an invalid assumption:

1. It assumed nodes start with autosizing disabled
2. It expected applying AutoSizingReserved: true to enable autosizing for the first time
3. It expected this state change to alter allocatable memory

What actually happens now:

1. Worker nodes already have autosizing enabled by default
2. Test applies AutoSizingReserved: true → no state change (already enabled)
3. Allocatable memory stays the same → assertion fails ❌

Solution
I removed the allocatable memory assertion

Related: #5491

- How to verify it

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[ngopalak-redhat]

/test all

[ngopalak-redhat]

/retest-required

[djoshy]

/retest

[deepsm007]

/retest

[djoshy]

/lgtm

Seems sane to me, and it is passing the e2e now.

/verified by e2es

This is only a test change, so no QE testing is required.

[openshift-ci-robot]

@djoshy: This PR has been marked as verified by e2es.

Details

In response to this:

/lgtm

Seems sane to me, and it is passing the e2e now.

/verified by e2es

This is only a test change, so no QE testing is required.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djoshy, ngopalak-redhat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [djoshy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 1e2c4ec and 2 for PR HEAD 56ac35a in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 17f2341 and 1 for PR HEAD 56ac35a in total

[djoshy]

This will need to be backported to 4.21 as well, so might need an actual bug backing it. Unless we can find a staff to override the cherry pick label requirment for 4.21.

[openshift-ci]

@ngopalak-redhat: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/bootstrap-unit	56ac35a	link	false	/test bootstrap-unit

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[djoshy]

/retitle "OCPBUGS-74101: Fixes the issue in the test TestKubeletConfigMaxPods when AutoNodeSizing is enabled by default"

[openshift-ci-robot]

@ngopalak-redhat: Jira Issue Verification Checks: Jira Issue OCPBUGS-74101
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-74101 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

- What I did
Reported by @djoshy : https://redhat-internal.slack.com/archives/CK1AE4ZCK/p1768319412897509

The TestKubeletConfigMaxPods test has been failing intermittently since PR #5491 merged. The failure occurs at the allocatable memory assertion:

 kubeletcfg_test.go:172:
     Error:      	Should not be: 13435936768
     Test:       	TestKubeletConfigMaxPods
     Messages:   	value of the allocatable should have changed

PR #5491 changed the default behavior for worker nodes:

Before PR #5491:

• NODE_SIZING_ENABLED=false (autosizing disabled by default)
• System reserved memory: 1GB (static)

After PR #5491:

• NODE_SIZING_ENABLED=true (autosizing enabled by default for non-Hypershift clusters)
• System reserved memory: ~2GB (dynamically calculated)

The test at kubeletcfg_test.go:165-173 made an invalid assumption:

1. It assumed nodes start with autosizing disabled
2. It expected applying AutoSizingReserved: true to enable autosizing for the first time
3. It expected this state change to alter allocatable memory

What actually happens now:

1. Worker nodes already have autosizing enabled by default
2. Test applies AutoSizingReserved: true → no state change (already enabled)
3. Allocatable memory stays the same → assertion fails ❌

Solution
I removed the allocatable memory assertion

Related: #5491

- How to verify it

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[djoshy]

/cherry-pick release-4.21

[openshift-cherrypick-robot]

@djoshy: new pull request created: #5567

Details

In response to this:

/cherry-pick release-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.