Skip to content

Fix squash merge regex #1118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
May 5, 2022
Merged

Fix squash merge regex #1118

openshift-merge-robot merged 1 commit into from
May 5, 2022

Conversation

@ardaguclu
Copy link
Member

@ardaguclu ardaguclu commented Apr 28, 2022 •
edited
Loading

As stated in here #1116 (comment),
current squash-merge regex does not cover the cases when PR subject also
contains some other PR reference(#123).

This PR fixes squash merge regex to also cover the cases where
PR subject also contains some other PR number.

@ardaguclu
Fix squash merge regex
d0feebb 
This PR fixes squash merge regex to also cover the cases where
PR subject also contains some other PR number.
@openshift-ci openshift-ci bot requested review from deads2k and soltysh April 28, 2022 09:31
@ardaguclu
Copy link
Member Author

ardaguclu commented Apr 28, 2022

/uncc @deads2k
/cc @deejross

@openshift-ci openshift-ci bot requested review from rosspeoples and removed request for deads2k April 28, 2022 09:31
@ardaguclu
Copy link
Member Author

ardaguclu commented Apr 28, 2022

/retest-required

@rosspeoples
Copy link

rosspeoples commented Apr 28, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 28, 2022
@ardaguclu
Copy link
Member Author

ardaguclu commented Apr 28, 2022

/test e2e-aws-upgrade

1 similar comment
@ardaguclu
Copy link
Member Author

ardaguclu commented May 5, 2022

/test e2e-aws-upgrade

soltysh
soltysh approved these changes May 5, 2022
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 5, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ardaguclu, deejross, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 5, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 5, 2022

@ardaguclu: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 68db9b2 into openshift:master May 5, 2022
@ardaguclu ardaguclu deleted the fix-squash-regex branch May 5, 2022 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rosspeoples rosspeoples Awaiting requested review from rosspeoples

1 more reviewer

@soltysh soltysh soltysh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rosspeoples rosspeoples

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ardaguclu @rosspeoples @soltysh @openshift-merge-robot