Skip to content

pkg/cli/admin/upgrade: Add post-period to space to some error messages #1330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Jun 19, 2023
Merged

pkg/cli/admin/upgrade: Add post-period to space to some error messages #1330

openshift-merge-robot merged 1 commit into from
Jun 19, 2023

Conversation

@wking
Copy link
Member

@wking wking commented Jan 26, 2023

Cleaning up some nits from 6c8d935 (#986).

@wking
pkg/cli/admin/upgrade: Add post-period to space to some error messages
6a9508c 
Cleaning up some nits from 6c8d935 (Adding the flag
--allow-not-recommended to oc adm upgrade, 2021-12-16, openshift#986).
@openshift-ci openshift-ci bot requested review from deads2k and soltysh January 26, 2023 18:05
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 26, 2023
@openshift-bot
Copy link
Contributor

openshift-bot commented Apr 27, 2023

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 27, 2023
@openshift-bot
Copy link
Contributor

openshift-bot commented May 27, 2023

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 27, 2023
LalatenduMohanty
LalatenduMohanty approved these changes Jun 8, 2023
View reviewed changes
Copy link
Member

@LalatenduMohanty LalatenduMohanty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 8, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LalatenduMohanty, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wking
Copy link
Member Author

wking commented Jun 9, 2023

/remove-lifecycle rotten

@openshift-ci openshift-ci bot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Jun 9, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 19, 2023

/retest-required

Remaining retests: 0 against base HEAD fcd8518 and 2 for PR HEAD 6a9508c in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 19, 2023 •
edited
Loading

@wking: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-ovn-ipv6 6a9508c link false /test e2e-metal-ipi-ovn-ipv6

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 19, 2023

/retest-required

Remaining retests: 0 against base HEAD f8c5669 and 1 for PR HEAD 6a9508c in total

@openshift-merge-robot openshift-merge-robot merged commit 3b2ad03 into openshift:master Jun 19, 2023
@wking wking mentioned this pull request Jun 20, 2023
Closed
@wking wking deleted the conditional-update-only-whitespace branch July 18, 2023 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@soltysh soltysh Awaiting requested review from soltysh

1 more reviewer

@LalatenduMohanty LalatenduMohanty LalatenduMohanty approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@LalatenduMohanty LalatenduMohanty

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@wking @openshift-bot @openshift-ci-robot @LalatenduMohanty @openshift-merge-robot