OTA-1600: pkg/cli/admin/upgrade/recommend: Don't error on unaccepted issues when the feature gate is off #2069
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@wking: This pull request references OTA-1600 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
approved
…n the feature gate is off When OC_ENABLE_CMD_UPGRADE_RECOMMEND_ACCEPT is not set to true, the --accept option does not exist. In that case, we don't want to error with [1]: error: issues that apply to this cluster but which were not included in --accept: ConditionalUpdateRisk Instead, we just want to exit happily, because we've already mentioned the issue earlier in the message. [1]: https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/29831/pull-ci-openshift-origin-main-e2e-aws-ovn-serial-1of2/1951653929842380800
wking
force-pushed
the
do-not-error-on-unaccepted-when-feature-gate-is-off
branch
from
1f897d8 to
b74a129
Compare
|
@wking: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/label qe-approved |
openshift-ci
bot
added
the
qe-approved
|
@wking: This pull request references OTA-1600 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JianLi-RH, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 1073b97
into
openshift:main
|
[ART PR BUILD NOTIFIER] Distgit: openshift-enterprise-cli |
|
[ART PR BUILD NOTIFIER] Distgit: ose-tools |
|
[ART PR BUILD NOTIFIER] Distgit: openshift-enterprise-deployer |
|
[ART PR BUILD NOTIFIER] Distgit: ose-cli-artifacts |
To make that functionality generally available. This could be a more thorough overhaul, e.g. I could drop the precheckEnabled knob entirely. But I'm doing the smallest possible pivot now, in case folks want to backport to older 4.y. And I can do the dev-branch polishing later on. The: error: issues that apply to this cluster but which were not included in --accept: AlertNoTestData,ConditionalUpdateRisk output that b74a129 (pkg/cli/admin/upgrade/recommend: Don't error on unaccepted issues when the feature gate is off, 2025-08-02, openshift#2069) had removed from the test fixtures is back, now that the accept gate is enabled by default (and thus newly enabled for the test suite).
To make that functionality generally available. This could be a more thorough overhaul, e.g. I could drop the precheckEnabled knob entirely. But I'm doing the smallest possible pivot now, in case folks want to backport to older 4.y. And I can do the dev-branch polishing later on. The: error: issues that apply to this cluster but which were not included in --accept: AlertNoTestData,ConditionalUpdateRisk output that b74a129 (pkg/cli/admin/upgrade/recommend: Don't error on unaccepted issues when the feature gate is off, 2025-08-02, openshift#2069) had removed from the test fixtures is back, now that the accept gate is enabled by default (and thus newly enabled for the test suite).
4 participants
When
OC_ENABLE_CMD_UPGRADE_RECOMMEND_ACCEPTis not set to true, the--acceptoption does not exist. In that case, we don't want to error with:Instead, we just want to exit happily, because we've already mentioned the issue earlier in the message.