pkg/cli/admin/upgrade: Display the upstream and channel #394
Conversation
When users want to know what channel they're in, make life more convienent then pointing them at a bare 'oc get clusterversion' [1]. [1]: https://github.com/openshift/openshift-docs/blame/c710f7cf5fe8327d6d4275b8a894efb08cc80342/modules/update-upgrading-cli.adoc#L34-L38
|
@wking: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| } | ||
| if len(cv.Spec.Upstream) > 0 && len(cv.Spec.Channel) > 0 { // if these are unset, we notify the user via RetrievedUpdates handling below | ||
| fmt.Fprintf(o.Out, "Cluster is watching %s for updates in channel %s\n", cv.Spec.Upstream, cv.Spec.Channel) | ||
| } |
There was a problem hiding this comment.
So as per the PR when users runs the oc adm upgrade command we show the user the Cincinnati API link and the channel name, right? I do think this is a good UX as user has asked for upgrades not for the details. I wonder if this is right place for this kind of information. Ideally we should have a command which should information about the cluster to the user and this information should be part of that command output.
There was a problem hiding this comment.
Ideally we should have a command which should information about the cluster to the user and this information should be part of that command output.
Knowing your upstream and channel gives context for the update source. Otherwise we can... point them at oc get clusterversion -o=jsonpath..., which seems... at least hard to remember. You don't like oc adm upgrade listing the source from which it pulled the available updates along with the "current" version?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
openshift-ci-robot
added
the
lifecycle/stale
|
Obsoleted by #576. Hopefully that one doesn't rot out too :p. /close |
|
@wking: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
4 participants
When users want to know what channel they're in, make life more convienent then pointing them at a bare
oc get clusterversion.