Skip to content

Bug 1827486: clarify usage of 'oc adm create-kubeconfig' #435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-robot merged 2 commits into from
Jun 17, 2020
Merged

Bug 1827486: clarify usage of 'oc adm create-kubeconfig' #435

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a2ae72b
Deprecate 'oc adm create-kubeconfig'
sallyom Jun 15, 2020
c19bb5d
generated
sallyom Jun 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
65 changes: 0 additions & 65 deletions contrib/completions/bash/oc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2098,70 +2098,6 @@ _oc_adm_create-error-template()
noun_aliases=()
}

_oc_adm_create-kubeconfig()
{
last_command="oc_adm_create-kubeconfig"

command_aliases=()

commands=()

flags=()
two_word_flags=()
local_nonpersistent_flags=()
flags_with_completion=()
flags_completion=()

flags+=("--master=")
two_word_flags+=("--master")
local_nonpersistent_flags+=("--master=")
flags+=("--public-master=")
two_word_flags+=("--public-master")
local_nonpersistent_flags+=("--public-master=")
flags+=("--as=")
two_word_flags+=("--as")
flags+=("--as-group=")
two_word_flags+=("--as-group")
flags+=("--cache-dir=")
two_word_flags+=("--cache-dir")
flags+=("--certificate-authority=")
two_word_flags+=("--certificate-authority")
flags+=("--client-certificate=")
two_word_flags+=("--client-certificate")
flags+=("--client-key=")
two_word_flags+=("--client-key")
flags+=("--cluster=")
two_word_flags+=("--cluster")
flags+=("--context=")
two_word_flags+=("--context")
flags+=("--insecure-skip-tls-verify")
flags+=("--kubeconfig=")
two_word_flags+=("--kubeconfig")
flags+=("--match-server-version")
flags+=("--namespace=")
two_word_flags+=("--namespace")
flags_with_completion+=("--namespace")
flags_completion+=("__oc_get_namespaces")
two_word_flags+=("-n")
flags_with_completion+=("-n")
flags_completion+=("__oc_get_namespaces")
flags+=("--request-timeout=")
two_word_flags+=("--request-timeout")
flags+=("--server=")
two_word_flags+=("--server")
two_word_flags+=("-s")
flags+=("--tls-server-name=")
two_word_flags+=("--tls-server-name")
flags+=("--token=")
two_word_flags+=("--token")
flags+=("--user=")
two_word_flags+=("--user")

must_have_one_flag=()
must_have_one_noun=()
noun_aliases=()
}

_oc_adm_create-login-template()
{
last_command="oc_adm_create-login-template"
Expand Down Expand Up @@ -6575,7 +6511,6 @@ _oc_adm()
commands+=("cordon")
commands+=("create-bootstrap-project-template")
commands+=("create-error-template")
commands+=("create-kubeconfig")
commands+=("create-login-template")
commands+=("create-provider-selection-template")
commands+=("drain")
Expand Down
65 changes: 0 additions & 65 deletions contrib/completions/zsh/oc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2240,70 +2240,6 @@ _oc_adm_create-error-template()
noun_aliases=()
}

_oc_adm_create-kubeconfig()
{
last_command="oc_adm_create-kubeconfig"

command_aliases=()

commands=()

flags=()
two_word_flags=()
local_nonpersistent_flags=()
flags_with_completion=()
flags_completion=()

flags+=("--master=")
two_word_flags+=("--master")
local_nonpersistent_flags+=("--master=")
flags+=("--public-master=")
two_word_flags+=("--public-master")
local_nonpersistent_flags+=("--public-master=")
flags+=("--as=")
two_word_flags+=("--as")
flags+=("--as-group=")
two_word_flags+=("--as-group")
flags+=("--cache-dir=")
two_word_flags+=("--cache-dir")
flags+=("--certificate-authority=")
two_word_flags+=("--certificate-authority")
flags+=("--client-certificate=")
two_word_flags+=("--client-certificate")
flags+=("--client-key=")
two_word_flags+=("--client-key")
flags+=("--cluster=")
two_word_flags+=("--cluster")
flags+=("--context=")
two_word_flags+=("--context")
flags+=("--insecure-skip-tls-verify")
flags+=("--kubeconfig=")
two_word_flags+=("--kubeconfig")
flags+=("--match-server-version")
flags+=("--namespace=")
two_word_flags+=("--namespace")
flags_with_completion+=("--namespace")
flags_completion+=("__oc_get_namespaces")
two_word_flags+=("-n")
flags_with_completion+=("-n")
flags_completion+=("__oc_get_namespaces")
flags+=("--request-timeout=")
two_word_flags+=("--request-timeout")
flags+=("--server=")
two_word_flags+=("--server")
two_word_flags+=("-s")
flags+=("--tls-server-name=")
two_word_flags+=("--tls-server-name")
flags+=("--token=")
two_word_flags+=("--token")
flags+=("--user=")
two_word_flags+=("--user")

must_have_one_flag=()
must_have_one_noun=()
noun_aliases=()
}

_oc_adm_create-login-template()
{
last_command="oc_adm_create-login-template"
Expand Down Expand Up @@ -6717,7 +6653,6 @@ _oc_adm()
commands+=("cordon")
commands+=("create-bootstrap-project-template")
commands+=("create-error-template")
commands+=("create-kubeconfig")
commands+=("create-login-template")
commands+=("create-provider-selection-template")
commands+=("drain")
Expand Down
1 change: 1 addition & 0 deletions pkg/cli/admin/createkubeconfig/create_kubeconfig.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ func NewCommandCreateKubeConfig(commandName string, fullName string, streams gen
kcmdutil.CheckErr(err)
}
},
Deprecated: "and will be removed in the future version",
}

cmd.Flags().StringVar(&o.APIServerURL, "master", o.APIServerURL, "The API server's URL.")
Expand Down