-
Notifications
You must be signed in to change notification settings - Fork 1.9k
fixing release version syntax #19380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/LGTM |
|
The preview will be available shortly at: |
|
@jianlinliu, will you PTAL? |
|
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless you're installing for another arch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wking, I'm not aware that another arch is currently available for 4.3. Is the syntax for Z going to be 4.3.x-s390x?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wking, who should I check with about suffixes for other arches?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Talk to ART about suffixes for other arches and official release timelines. But personally I think we want #19266 so we don't need to care about what ART decides to use for tag names ;).
97dd4a2 to
4e0469f
Compare
|
New changes are detected. LGTM label has been removed. |
|
attaching to https://bugzilla.redhat.com/show_bug.cgi?id=1795544 @jianlinliu, I've made an update to match the bug. Please let me know if you want to merge this change or just wait for all the issues on #19266 to be resolved and merge that instead. |
|
I am okay to merget this change now. |
|
@openshift/team-documentation, PTAL? |
|
LGTM |
|
/cherrypick enterprise-4.3 |
|
/cherrypick enterprise-4.4 |
|
@kalexand-rh: new pull request created: #19748 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@kalexand-rh: new pull request created: #19749 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Per @mazzystr in Slack.
@wking, does this sound right to you?