Skip to content

Conversation

@kalexand-rh
Copy link
Contributor

Per @mazzystr in Slack.

@wking, does this sound right to you?

@kalexand-rh kalexand-rh added this to the Next Release milestone Jan 29, 2020
@kalexand-rh kalexand-rh self-assigned this Jan 29, 2020
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 29, 2020
@mazzystr
Copy link

/LGTM

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 29, 2020
@openshift-docs-preview-bot

The preview will be available shortly at:

@kalexand-rh
Copy link
Contributor Author

@jianlinliu, will you PTAL?

@jianlinliu
Copy link

LGTM

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless you're installing for another arch?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wking, I'm not aware that another arch is currently available for 4.3. Is the syntax for Z going to be 4.3.x-s390x?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wking, who should I check with about suffixes for other arches?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talk to ART about suffixes for other arches and official release timelines. But personally I think we want #19266 so we don't need to care about what ART decides to use for tag names ;).

@openshift-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 13, 2020
@kalexand-rh
Copy link
Contributor Author

attaching to https://bugzilla.redhat.com/show_bug.cgi?id=1795544

@jianlinliu, I've made an update to match the bug. Please let me know if you want to merge this change or just wait for all the issues on #19266 to be resolved and merge that instead.

@jianlinliu
Copy link

I am okay to merget this change now.

@kalexand-rh kalexand-rh added the peer-review-needed Signifies that the peer review team needs to review this PR label Feb 14, 2020
@kalexand-rh
Copy link
Contributor Author

@openshift/team-documentation, PTAL?

@bmcelvee
Copy link
Contributor

LGTM

@bmcelvee bmcelvee added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Feb 14, 2020
@kalexand-rh kalexand-rh merged commit 1f0616c into openshift:master Feb 14, 2020
@kalexand-rh
Copy link
Contributor Author

/cherrypick enterprise-4.3

@kalexand-rh
Copy link
Contributor Author

/cherrypick enterprise-4.4

@openshift-cherrypick-robot

@kalexand-rh: new pull request created: #19748

Details

In response to this:

/cherrypick enterprise-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@kalexand-rh: new pull request created: #19749

Details

In response to this:

/cherrypick enterprise-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.3 branch/enterprise-4.4 peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants