*: Rename bastion -> mirror host #19435
Conversation
openshift-ci-robot
added
the
size/L
wking
force-pushed
the
rename-bastion-to-mirror-host
branch
from
9c3b13e to
91dbff4
Compare
wking
changed the title
kalexand-rh
left a comment
kalexand-rh
left a comment
There was a problem hiding this comment.
Our style guide forbids the use of "may," and that's really the only issue that i see. Most of the repetition is either due to the fact that there's a separate assembly for each disconnected installation or the fact that there are separate yaml samples for each installation type. (If I see a good opportunity to clean up the latter, I will.)
There was a problem hiding this comment.
That was a reminder for myself that I didn't need to install the CLI as part of the installation process. You install from the mirror host and already have it installed. (Also, "may" doesn't translate well, so I wouldn't add it.)
There was a problem hiding this comment.
I get that you're trying to step back from the bastion, but do you have a particular workflow in mind? "May implies permission, and that's not really what we mean here.
I'd either you may or, if you want to back it off more and still want them to use the installer that they generated from the mirror repo, say something like "Because the installation media is on the mirror host, the following steps assume that you use that computer to complete all installation steps. If you cannot complete the {product-title} installation from the mirror host, use the method that best fits your restrictions to ensure that you use the installation program that you generated from the mirrored content."
This is part of decoupling our docs from the assumption that a bastion will exist. For installation, we just care that there is a registry with the mirrored content that the cluster can pull from. Having that registry on a bastion makes creating the mirrored images easier, but as our existing docs hint, there are other ways you can get the mirrored images in to your mirror repository. This commit borrows its motivation and some of its wording from Clayton's [1]. Also push the port information into <mirror_registry>, because we want to make it clear that we don't require a port for these entries. The previous content was not consistent about whether placeholder were referenced with or without their wrapping <>. In my new text, I've included the <> to make it more clear that they are part of the placeholder, and not literal characters that should remain after placeholder substitution. [1]: openshift#17896 (comment)
kalexand-rh
force-pushed
the
rename-bastion-to-mirror-host
branch
from
91dbff4 to
6973df0
Compare
|
@jianlinliu,will you PTAL? @wking, I want to merge this as soon as Jianlin blesses it so I can resolve any conflicts with Clayton's PR. |
|
LGTM |
|
Don't block on me. I can always file further suggestions in the off chance I notice anything post-merge. |
|
/cherrypick enterprise-4.2 |
|
/cherrypick enterprise-4.3 |
|
@kalexand-rh: #19435 failed to apply on top of branch "enterprise-4.2": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@kalexand-rh: #19435 failed to apply on top of branch "enterprise-4.3": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick enterprise-4.4 |
|
@kalexand-rh: #19435 failed to apply on top of branch "enterprise-4.4": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick enterprise-4.5 |
|
@kalexand-rh: new pull request created: #23217 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
5 participants
This is part of decoupling our docs from the assumption that a bastion will exist. For installation, we just care that there is a registry with the mirrored content that the cluster can pull from. Having that
registry on a bastion makes creating the mirrored images easier, but as our existing docs hint, there are other ways you can get the mirrored images in to your mirror repository. This commit borrows its motivation and some of its wording from @smarterclayton's here.
Also push the port information into
<mirror_registry>, because we want to make it clear that we don't require a port for these entries. The previous content was not consistent about whether placeholder werereferenced with or without their wrapping
<>. In my new text, I've included the<>to make it more clear that they are part of the placeholder, and not literal characters that should remain after placeholder substitution.CC @kalexand-rh. There's a lot of duplicate-ish content in here. Any ideas for DRYing it up?