Skip to content

Conversation

@kalexand-rh
Copy link
Contributor

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 10, 2020
@kalexand-rh
Copy link
Contributor Author

@jianlinliu, since https://bugzilla.redhat.com/show_bug.cgi?id=1806782 has merged, do you have any objections to adding this doc to 4.3? (@wking, FYI)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think 4.3 support this feature, especially --apply-release-image-signature

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm removing this option and rewording the other one a bit.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the other hand, here we removed If the local container registry and the cluster are connected to the mirror host, directly push the release images to the local registry scenario, right? I think this scenario is still valid, just not support --apply-release-image-signature option, that means user can run oc adm release mirror -a ${LOCAL_SECRET_JSON} --from=quay.io/${PRODUCT_REPO}/${RELEASE_NAME}:${OCP_RELEASE}-${ARCHITECTURE} --to=${LOCAL_REGISTRY}/${LOCAL_REPOSITORY}, then need to create an image signature ConfigMap manually.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This perfectly aligns with what Lala was saying about the disconnected update scenario for 4.3. I think that it will be easier to capture this change in a PR to backport the disconnected update method for 4.3. I'm removing this file from the PR. Are these changes to just the install method ok to merge?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jianlinliu, since #24971 is going to address the ConfigMap, is this PR ready to merge?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

4.3 contains changes that simplify working with credentials and true
disconnected. Updating the docs (draft) to capture the differences
and deemphasize the custom bastion, and encourage using your own.

More details about what is required from a mirror registry.

Try to split out the bits of steps for disconnected and connected
mirroring. There are connected mirror use cases.
@kalexand-rh kalexand-rh merged commit d6d757c into openshift:enterprise-4.3 Sep 8, 2020
@kalexand-rh kalexand-rh deleted the 17896_4.3 branch September 8, 2020 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants