BZ-1857788 Added note about workaround for VMs using HPP #24172
Conversation
openshift-ci-robot
added
the
size/XS
|
The preview will be available shortly at: |
openshift-ci-robot
added
size/S
sjhala-ccs
force-pushed
the
BZ-1857788
branch
2 times, most recently
from
bfc7fd2 to
a9f574d
Compare
|
/lgtm |
|
@rnetser: changing LGTM is restricted to collaborators DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
ousleyp
left a comment
ousleyp
left a comment
There was a problem hiding this comment.
This mostly looks great but I have one very minor fix and a couple of nitpicky suggestions. Take 'em or leave 'em. :) Thanks, Shikha!
ousleyp
added
branch/enterprise-4.5
branch/enterprise-4.6
CNV
openshift-ci-robot
added
size/XS
|
/cherrypick enterprise-4.5 |
|
/cherrypick enterprise-4.6 |
|
@ousleyp: new pull request created: #24801 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@ousleyp: new pull request created: #24802 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
xrefs aren't allowed in modules: $ grep -A1 'You must not include xrefs' modules/mod-docs-ocp-conventions.adoc You must not include xrefs in modules or create an xref to a module. You can only use xrefs to link from one assembly to another. But this module only has a single consumer: $ git --no-pager grep 'include.*virt-about-upgrading-virt' origin/master origin/master:virt/upgrading-virt.adoc:include::modules/virt-about-upgrading-virt.adoc[leveloffset=+1] So shift it into the virt/ assembly to allow the xref added in 87623ba (BZ-1857788 Added note about upgrade workaround for VMs using HPP, 2020-07-24, openshift#24172).
| This includes virtual machines that use hostpath provisioner storage or SR-IOV network interfaces. | ||
| As a workaround, you can reconfigure the virtual machines so that they can be powered off automatically during a cluster upgrade. Remove the `evictionStrategy: LiveMigrate` field and | ||
| set the `runStrategy` field to `Always`. Learn more about xref:../virt/live_migration/virt-configuring-vmi-eviction-strategy.adoc#virt-configuring-vmi-eviction-strategy[configuring virtual machine eviction strategy]. |
There was a problem hiding this comment.
@ousleyp hey - reminder to check for xrefs in modules.
8 participants
BZ-1857788 https://bugzilla.redhat.com/show_bug.cgi?id=1857788
Added a note to remove evictionStrategy: LiveMigrate and use runStrategy: Always for VMs using hostpath-provisioner or SR-IOV network interfaces as a workaround for cluster upgrade issue
Preview build: https://bz-1857788--ocpdocs.netlify.app/openshift-enterprise/latest/virt/upgrading-virt.html#how-openshift-virtualization-upgrades-affect-your-cluster
Tagging @aglitke for SME review
Tagging @rnetser for QE review
Merge/CP to enterprise-4.5 and enterprise-4.6