modules/update-service-mirror-release: Use 'oc image mirror ...' for the release image #33841
Conversation
openshift-ci
bot
added
the
size/S
|
✔️ Deploy Preview for osdocs ready! 🔨 Explore the source changes: d49d9d6 🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/61004f33af888e0007bffb50 😎 Browse the preview: https://deploy-preview-33841--osdocs.netlify.app/openshift-enterprise/latest/updating/installing-update-service |
|
/lgtm |
|
@jiajliu, can you take a look? Because this is tweaking the original implementation that responded to your comment. |
|
I don't remember we ever hit the issue when using |
|
Checking on: It works and Anyway, LGTM. |
Correcting it. I can reproduce the issue. |
wking
force-pushed
the
update-service-release-image-mirror-fix
branch
from
7ecf7c9 to
5fa060b
Compare
|
New changes are detected. LGTM label has been removed. |
|
LGTM. |
|
NeedsTestCase |
bergerhoffer
left a comment
bergerhoffer
left a comment
There was a problem hiding this comment.
Just one minor formatting comment, but LGTM!
bergerhoffer
added
the
peer-review-done
|
@shellyyang1989 @jiajliu @soltysh Can anyone confirm whether this update should be applied to all supported OCP version (4.6+)? |
…the release image
We can't use:
$ oc adm release mirror ...
to split the release image out into LOCAL_RELEASE_IMAGES_REPOSITORY,
because oc does not currently understand mirroring. So there's no way
to tell it "the referenced images you're looking for are actually in
${LOCAL_REGISTRY}/${TEMP_REPOSITORY}", and it fails with:
error: unable to connect to quay.io/openshift-release-dev/ocp-v4.0-art-dev: Get "https://quay.io/v2/"...
error: an error occurred during planning
Instead, send the images from disk directly to the target repositoy
for referenced images, and then use 'oc image mirror' again to copy
the release image over to the release-image repository without
worrying about referenced images. We still need the release images in
that separate repository to avoid Cincinnati consuming excessive
memory trying to load referenced-image layers as if they were release
images [1,2].
I've also softened some REMOVABLE_MEDIA_PATH wording. The important
point is that REMOVABLE_MEDIA_PATH points to where the removable media
is mounted for both commands, not that you use the same path string.
For example, maybe you mounted to /mnt/a on your external machine, and
then mounted that media to /mnt/b on your internal machine. You'd
want to use /mnt/b for REMOVABLE_MEDIA_PATH when mirroring from disk,
not /mnt/a.
[1]: openshift#29630 (comment)
[2]: https://bugzilla.redhat.com/show_bug.cgi?id=1850781
wking
force-pushed
the
update-service-release-image-mirror-fix
branch
from
5fa060b to
d49d9d6
Compare
|
@bergerhoffer I think it's good to apply this update to OCP v4.6/v4.7/v4.8 since osus is supported on v4.6+. |
|
/cherrypick enterprise-4.9 |
|
/cherrypick enterprise-4.8 |
|
/cherrypick enterprise-4.7 |
|
/cherrypick enterprise-4.6 |
|
@bergerhoffer: new pull request created: #34971 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@bergerhoffer: new pull request created: #34972 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@bergerhoffer: new pull request created: #34973 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@bergerhoffer: new pull request created: #34974 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
6 participants
We can't use:
$ oc adm release mirror ...to split the release image out into
LOCAL_RELEASE_IMAGES_REPOSITORY, becauseocdoes not currently understand mirroring. So there's no way to tell it "the referenced images you're looking for are actually in${LOCAL_REGISTRY}/${TEMP_REPOSITORY}", and it fails with:Instead, send the images from disk directly to the target repositoy for referenced images, and then use
oc image mirroragain to copy the release image over to the release-image repository without worrying about referenced images. We still need the release images in that separate repository to avoid Cincinnati consuming excessive memory trying to load referenced-image layers as if they were release images (comment, rhbz#1850781).I've also softened some
REMOVABLE_MEDIA_PATHwording. The important point is thatREMOVABLE_MEDIA_PATHpoints to where the removable media is mounted for both commands, not that you use the same path string. For example, maybe you mounted to/mnt/aon your external machine, and then mounted that media to/mnt/bon your internal machine. You'd want to use/mnt/bfor REMOVABLE_MEDIA_PATH when mirroring from disk, not/mnt/a.