Skip to content

Conversation

@darshan-nagaraj
Copy link
Contributor

@darshan-nagaraj darshan-nagaraj commented Jun 6, 2022

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 6, 2022
@darshan-nagaraj darshan-nagaraj force-pushed the OSDOCS-3605-and-Gh-issue-40595 branch from f0a3093 to b217d05 Compare June 16, 2022 15:45
Copy link
Contributor

@tmalove tmalove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

openshift/oc#576 landed in the development branch and shipped with 4.9. So folks using a 4.8 oc won't have the channel subcommand available. That is narrowly acceptable, because we open this file with:

Install the OpenShift CLI (oc) that matches the version for your updated version.

But I'm not sure how many folks are following along that carefully, so it might be worth a reminder here that we want them to be using a 4.9 oc for this pre-update channel change, even though they are currently running a 4.8 cluster.

@wking
Copy link
Member

wking commented Jun 16, 2022

/lgtm

I'm fine with or without this adjustment.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 16, 2022
Copy link
Contributor

@jeana-redhat jeana-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits, mostly just the standard around "by running the following command" for commands.

Comment on lines 40 to 41
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
. View the available updates and note the version number of the update that
you want to apply:
. View the available updates by running the following command. Note the version number of the update that you want to apply.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
. Based on your organization requirements, set the upgrade channel to `stable-4.9`, `fast-4.9`, or `eus-4.10`:
. Based on your organization requirements, set the upgrade channel to `stable-4.9`, `fast-4.9`, or `eus-4.10` by running the following command:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
For example, to set the channel to `stable-4.9`:
For example, to set the channel to `stable-4.9`, run the following command:

@jeana-redhat jeana-redhat added peer-review-done Signifies that the peer review team has reviewed this PR branch/enterprise-4.9 labels Jun 16, 2022
@jeana-redhat jeana-redhat added this to the Next Release milestone Jun 16, 2022
Copy link

@jiajliu jiajliu Jun 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The step 2 and step 3 should be switched. We should set channel correctly first, and then it will show available update correctly. For example in this pr, if users don't set channel to stable-4.9 as step 3, then the available update should not be like the one in step 2(including v4.9.*)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A quick check on v4.10, the same issue.

@darshan-nagaraj darshan-nagaraj force-pushed the OSDOCS-3605-and-Gh-issue-40595 branch from b217d05 to f25a193 Compare July 10, 2022 19:50
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 10, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jul 10, 2022

New changes are detected. LGTM label has been removed.

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 18, 2022
@openshift-bot
Copy link

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 18, 2022
@openshift-bot
Copy link

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci openshift-ci bot closed this Jan 18, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jan 18, 2023

@openshift-bot: Closed this PR.

Details

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.9 lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants