-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[enterprise-4.9]OSDOCS-3605-and-Gh-issue-40595: Updates cluster CLI update procedure #46338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[enterprise-4.9]OSDOCS-3605-and-Gh-issue-40595: Updates cluster CLI update procedure #46338
Conversation
f0a3093 to
b217d05
Compare
tmalove
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
modules/update-upgrading-cli.adoc
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
openshift/oc#576 landed in the development branch and shipped with 4.9. So folks using a 4.8 oc won't have the channel subcommand available. That is narrowly acceptable, because we open this file with:
Install the OpenShift CLI (
oc) that matches the version for your updated version.
But I'm not sure how many folks are following along that carefully, so it might be worth a reminder here that we want them to be using a 4.9 oc for this pre-update channel change, even though they are currently running a 4.8 cluster.
|
/lgtm I'm fine with or without this adjustment. |
jeana-redhat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nits, mostly just the standard around "by running the following command" for commands.
modules/update-upgrading-cli.adoc
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| . View the available updates and note the version number of the update that | |
| you want to apply: | |
| . View the available updates by running the following command. Note the version number of the update that you want to apply. |
modules/update-upgrading-cli.adoc
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| . Based on your organization requirements, set the upgrade channel to `stable-4.9`, `fast-4.9`, or `eus-4.10`: | |
| . Based on your organization requirements, set the upgrade channel to `stable-4.9`, `fast-4.9`, or `eus-4.10` by running the following command: |
modules/update-upgrading-cli.adoc
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| For example, to set the channel to `stable-4.9`: | |
| For example, to set the channel to `stable-4.9`, run the following command: |
modules/update-upgrading-cli.adoc
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The step 2 and step 3 should be switched. We should set channel correctly first, and then it will show available update correctly. For example in this pr, if users don't set channel to stable-4.9 as step 3, then the available update should not be like the one in step 2(including v4.9.*)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A quick check on v4.10, the same issue.
b217d05 to
f25a193
Compare
|
New changes are detected. LGTM label has been removed. |
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
|
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
|
Rotten issues close after 30d of inactivity. Reopen the issue by commenting /close |
|
@openshift-bot: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Version(s): 4.9
Issue: https://issues.redhat.com/browse/OSDOCS-3605 and #40595
Link to docs preview: http://file.rdu.redhat.com/dnagaraj/OSDOCS-3605-and-Gh-issue-40595/updating/updating-cluster-cli.html#update-upgrading-cli_updating-cluster-cli
Additional information: Relates to #45326 and #45663