Skip to content

osdocs9673: hiding sigstore section until 4.17 #77203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ShaunaDiaz merged 1 commit into from
Jun 10, 2024
Merged

osdocs9673: hiding sigstore section until 4.17 #77203

ShaunaDiaz merged 1 commit into from
Jun 10, 2024

Conversation

@DCChadwick
Copy link

@DCChadwick DCChadwick commented Jun 7, 2024 •
edited by openshift-ci bot
Loading

Version(s): 4.16

Issue: OSDOCS-9673

Link to docs preview:

Additional information: Sigstore features will not be available until 4.17. I'm commenting out this section of the topic map until then.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 7, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jun 7, 2024

🤖 Fri Jun 07 20:43:05 - Prow CI generated the docs preview:

https://77203--ocpdocs-pr.netlify.app/

@openshift-ci
Copy link

openshift-ci bot commented Jun 7, 2024

@DCChadwick: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@DCChadwick
Copy link
Author

DCChadwick commented Jun 10, 2024

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Jun 10, 2024
@mpandya15
Copy link
Contributor

mpandya15 commented Jun 10, 2024

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Jun 10, 2024
@JoeAldinger JoeAldinger removed the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Jun 10, 2024
JoeAldinger
JoeAldinger reviewed Jun 10, 2024
View reviewed changes
Copy link
Contributor

@JoeAldinger JoeAldinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@JoeAldinger JoeAldinger added the peer-review-done Signifies that the peer review team has reviewed this PR label Jun 10, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 10, 2024
@DCChadwick
Copy link
Author

DCChadwick commented Jun 10, 2024

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Jun 10, 2024
@ShaunaDiaz ShaunaDiaz added branch/enterprise-4.16 and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jun 10, 2024
@ShaunaDiaz ShaunaDiaz added this to the Continuous Release milestone Jun 10, 2024
@ShaunaDiaz
Copy link
Contributor

ShaunaDiaz commented Jun 10, 2024

/remove-label merge-review-needed

@ShaunaDiaz ShaunaDiaz merged commit fcee31a into openshift:main Jun 10, 2024
@ShaunaDiaz
Copy link
Contributor

ShaunaDiaz commented Jun 10, 2024

/cherrypick enterprise-4.16

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Jun 10, 2024

@ShaunaDiaz: new pull request created: #77265

Details

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 10, 2024
Merged
@openshift-ci openshift-ci bot removed the merge-review-needed Signifies that the merge review team needs to review this PR label Jun 10, 2024
@wking wking mentioned this pull request Sep 23, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoeAldinger JoeAldinger JoeAldinger left review comments

Assignees

@JoeAldinger JoeAldinger

Labels

branch/enterprise-4.16 lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

Continuous Release

Development

Successfully merging this pull request may close these issues.

6 participants

@DCChadwick @ocpdocs-previewbot @mpandya15 @ShaunaDiaz @openshift-cherrypick-robot @JoeAldinger