Skip to content

Conversation

@DCChadwick
Copy link

@DCChadwick DCChadwick commented Jul 2, 2024

Version(s): 4.17+

Issue: OSDOCS-9673

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 2, 2024
@ocpdocs-previewbot
Copy link

🤖 Tue Jul 02 19:36:25 - Prow CI generated the docs preview:

https://78396--ocpdocs-pr.netlify.app/

@openshift-ci
Copy link

openshift-ci bot commented Jul 2, 2024

@DCChadwick: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@DCChadwick
Copy link
Author

/label peer-review-needed

This PR is simply intended to unhide documentation that has already been through the review process.

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Jul 12, 2024
@skopacz1 skopacz1 added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Jul 12, 2024
Copy link
Contributor

@skopacz1 skopacz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Peer review LGTM since you say that all the content being added to the docs has already been reviewed

@skopacz1 skopacz1 added peer-review-done Signifies that the peer review team has reviewed this PR branch/enterprise-4.17 and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Jul 12, 2024
@skopacz1 skopacz1 added this to the Planned for 4.17 GA milestone Jul 12, 2024
@DCChadwick
Copy link
Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Jul 26, 2024
@jeana-redhat jeana-redhat added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Jul 26, 2024
Copy link
Contributor

@jeana-redhat jeana-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI it's still helpful to include a preview in this case (to make sure the TOC rendered as it ought to 🙂). I found it and it LGTM 🚀

/remove-label merge-review-in-progress
/remove-label merge-review-needed

@openshift-ci openshift-ci bot removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Jul 26, 2024
@jeana-redhat jeana-redhat merged commit 5f97c30 into openshift:main Jul 26, 2024
@jeana-redhat
Copy link
Contributor

/cherrypick enterprise-4.17

@openshift-cherrypick-robot

@jeana-redhat: new pull request created: #79549

Details

In response to this:

/cherrypick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.17 peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants