Skip to content

Nodes and MCO 4.18 release notes #86402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mburke5678 merged 1 commit into from
Feb 14, 2025
Merged

Nodes and MCO 4.18 release notes #86402

mburke5678 merged 1 commit into from
Feb 14, 2025

Conversation

@mburke5678
Copy link
Contributor

@mburke5678 mburke5678 commented Dec 17, 2024 •
edited
Loading

@mburke5678 mburke5678 added this to the Planned for 4.18 GA milestone Dec 17, 2024
@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 17, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Dec 17, 2024 •
edited
Loading

🤖 Thu Feb 13 18:45:01 - Prow CI generated the docs preview:

https://86402--ocpdocs-pr.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-18-release-notes.html

@openshift-ci openshift-ci bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 17, 2024
@mburke5678 mburke5678 force-pushed the nodes-release-notes-418 branch from b4cdaf9 to 381e8dc Compare January 15, 2025 21:44
@mburke5678 mburke5678 changed the title Nodes 4.18 release notes Nodes and MCO 4.18 release notes Feb 7, 2025
@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 7, 2025
@mburke5678 mburke5678 force-pushed the nodes-release-notes-418 branch from 6a3754e to 0a270cf Compare February 13, 2025 18:25
@mburke5678 mburke5678 force-pushed the nodes-release-notes-418 branch from 0a270cf to 5cb495d Compare February 13, 2025 18:31
@mburke5678 mburke5678 added the peer-review-needed Signifies that the peer review team needs to review this PR label Feb 13, 2025
@openshift-ci
Copy link

openshift-ci bot commented Feb 13, 2025

@mburke5678: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@cbippley
Copy link
Contributor

cbippley commented Feb 13, 2025

/label peer-review-in-progress
/remove-label peer-review-needed

@openshift-ci openshift-ci bot added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Feb 13, 2025
cbippley
cbippley reviewed Feb 13, 2025
View reviewed changes
Copy link
Contributor

@cbippley cbippley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny suggestion, LGTM!

release_notes/ocp-4-18-release-notes.adoc
==== Expanded image config nodes information (Technology Preview)
The image config nodes custom resource, which allows you to monitor the progress of machine configuration updates to nodes, now presents more information on the update. The output of the `oc get machineconfignodes` command now reports on the following and other conditions. You can use these statuses to follow the update, or troubleshoot the node if it experiences an error during the update:

* If each node was cordoned and uncordoned
Copy link
Contributor

@cbippley cbippley Feb 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* If each node was cordoned and uncordoned
* If each node was cordoned and uncordoned.

You have periods at the end of the list items below. Perhaps add them here to make the punctuation consistent.

Copy link
Contributor Author

@mburke5678 mburke5678 Feb 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These list items are not full sentences, where the other list items below are. Sentence fragments in lists do not take periods.

See the ISG.

@cbippley
Copy link
Contributor

cbippley commented Feb 13, 2025

/label peer-review-done
/remove-label peer-review-in-progress

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Feb 13, 2025
@mburke5678 mburke5678 merged commit 66a4c6f into openshift:enterprise-4.18 Feb 14, 2025
2 checks passed
@mburke5678 mburke5678 deleted the nodes-release-notes-418 branch February 14, 2025 14:12
dkhater-redhat
dkhater-redhat reviewed Feb 17, 2025
View reviewed changes
Copy link

@dkhater-redhat dkhater-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me! nice work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@dkhater-redhat dkhater-redhat dkhater-redhat left review comments

@cbippley cbippley cbippley left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

branch/enterprise-4.18 peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

OCP 4.18 GA

Development

Successfully merging this pull request may close these issues.

4 participants

@mburke5678 @ocpdocs-previewbot @cbippley @dkhater-redhat