noqe: operator-registry QoL improvements #362
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: perdasilva The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Contributor
Author
|
since no features or bug fixes are being introduced in this PR, qe approval is not needed |
perdasilva
force-pushed
the
qol_improvements
branch
from
c1579cc to
328f240
Compare
Contributor
Author
|
/retest |
Contributor
|
/lgtm |
perdasilva
force-pushed
the
qol_improvements
branch
from
328f240 to
b19b919
Compare
Contributor
|
test /e2e-gcp-console-olm |
Contributor
|
/retest |
1 similar comment
Contributor
|
/retest |
) This commit replaces `ioutil.TempDir` with `t.TempDir` in tests. The directory created by `t.TempDir` is automatically removed when the test and all its subtests complete. Prior to this commit, temporary directory created using `ioutil.TempDir` needs to be removed manually by calling `os.RemoveAll`, which is omitted in some tests. The error handling boilerplate e.g. defer func() { if err := os.RemoveAll(dir); err != nil { t.Fatal(err) } } is also tedious, but `t.TempDir` handles this for us nicely. Reference: https://pkg.go.dev/testing#T.TempDir Signed-off-by: Eng Zer Jun <[email protected]> Upstream-commit: 43e43240dd9c32dcb7742e96afb1ab3fd63a9ce2 Upstream-repository: operator-registry
Signed-off-by: timflannagan <[email protected]> Upstream-commit: 732b5722825e085c045b94fbb5ae36dcb8df59c3 Upstream-repository: operator-registry
Signed-off-by: timflannagan <[email protected]> Upstream-commit: 33ed9ea30b4daea03435c2ba3839a6ce79894a75 Upstream-repository: operator-registry
perdasilva
force-pushed
the
qol_improvements
branch
from
b19b919 to
d32082a
Compare
perdasilva
changed the title
Contributor
Author
|
/retest |
1 similar comment
Contributor
Author
|
/retest |
Contributor
|
@perdasilva: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
perdasilva
pushed a commit
to perdasilva/operator-framework-olm
that referenced
this pull request
Jan 15, 2025
Bumps [k8s.io/client-go](https://github.com/kubernetes/client-go) from 0.31.0 to 0.31.1. - [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md) - [Commits](kubernetes/client-go@v0.31.0...v0.31.1) --- updated-dependencies: - dependency-name: k8s.io/client-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Upstream-repository: api Upstream-commit: 675c8b7273539799c10757eec3932d552914874d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces no features of bug fixes. It includes some quality of life improvements to the operator-registry: test and script improvements