Skip to content

[release-4.10] OCPBUGS-1323: Add autoscaling eviction annotation to catalog pods to enable proper draining of nodes #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Oct 11, 2022
Merged

[release-4.10] OCPBUGS-1323: Add autoscaling eviction annotation to catalog pods to enable proper draining of nodes #392

openshift-merge-robot merged 1 commit into from
Oct 11, 2022

Conversation

@timflannagan
Copy link
Contributor

@timflannagan timflannagan commented Sep 22, 2022

Signed-off-by: Daniel Sover [email protected]
Upstream-repository: operator-lifecycle-manager
Upstream-commit: dbd5b6f0d1dbc6981363c1345fa217629de97709

@exdx @timflannagan
fix: add autoscaling eviction annotation to catalog pods to enable pr…
ae10530 
…oper draining of nodes (#2669)

Signed-off-by: Daniel Sover <[email protected]>
Upstream-repository: operator-lifecycle-manager
Upstream-commit: dbd5b6f0d1dbc6981363c1345fa217629de97709
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 22, 2022

@timflannagan: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 22, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: timflannagan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 22, 2022
@timflannagan
Copy link
Contributor Author

timflannagan commented Sep 22, 2022

/retitle release-4.10] OCPBUGS-1323: Add autoscaling eviction annotation to catalog pods to enable proper draining of nodes

@openshift-ci openshift-ci bot changed the title test release-4.10] OCPBUGS-1323: Add autoscaling eviction annotation to catalog pods to enable proper draining of nodes Sep 22, 2022
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Sep 22, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 22, 2022

@timflannagan: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

release-4.10] OCPBUGS-1323: Add autoscaling eviction annotation to catalog pods to enable proper draining of nodes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 22, 2022

@timflannagan: This pull request references Jira Issue OCPBUGS-1323, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.10.z) matches configured target version for branch (4.10.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-1431 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-1431 targets the "4.11.z" version, which is one of the valid target versions: 4.11.0, 4.11.z
  • bug has dependents

Requesting review from QA contact:
/cc @kuiwang02

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Signed-off-by: Daniel Sover [email protected]
Upstream-repository: operator-lifecycle-manager
Upstream-commit: dbd5b6f0d1dbc6981363c1345fa217629de97709

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Sep 22, 2022
@timflannagan
Copy link
Contributor Author

timflannagan commented Sep 22, 2022

/retitle [release-4.10] OCPBUGS-1323: Add autoscaling eviction annotation to catalog pods to enable proper draining of nodes

@openshift-ci openshift-ci bot requested a review from kuiwang02 September 22, 2022 19:42
@openshift-ci openshift-ci bot changed the title release-4.10] OCPBUGS-1323: Add autoscaling eviction annotation to catalog pods to enable proper draining of nodes [release-4.10] OCPBUGS-1323: Add autoscaling eviction annotation to catalog pods to enable proper draining of nodes Sep 22, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 22, 2022

@timflannagan: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Retaining the bugzilla/valid-bug label as it was manually added.

Details

In response to this:

[release-4.10] OCPBUGS-1323: Add autoscaling eviction annotation to catalog pods to enable proper draining of nodes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@timflannagan
Copy link
Contributor Author

timflannagan commented Sep 22, 2022

/retest

2 similar comments
@timflannagan
Copy link
Contributor Author

timflannagan commented Sep 23, 2022

/retest

@timflannagan
Copy link
Contributor Author

timflannagan commented Sep 29, 2022

/retest

@oceanc80
Copy link
Contributor

oceanc80 commented Sep 30, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 30, 2022
@timflannagan
Copy link
Contributor Author

timflannagan commented Oct 3, 2022

/retest

@bandrade
Copy link
Contributor

bandrade commented Oct 4, 2022

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Oct 4, 2022
@perdasilva
Copy link
Contributor

perdasilva commented Oct 6, 2022

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Oct 6, 2022
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 6, 2022

/retest-required

Remaining retests: 0 against base HEAD fa8fd46 and 2 for PR HEAD ae10530 in total

@oceanc80
Copy link
Contributor

oceanc80 commented Oct 6, 2022

/retest

@oceanc80
Copy link
Contributor

oceanc80 commented Oct 7, 2022

/retest

3 similar comments
@oceanc80
Copy link
Contributor

oceanc80 commented Oct 10, 2022

/retest

@oceanc80
Copy link
Contributor

oceanc80 commented Oct 10, 2022

/retest

@oceanc80
Copy link
Contributor

oceanc80 commented Oct 10, 2022

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 10, 2022 •
edited
Loading

@timflannagan: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-olm ae10530 link true /test e2e-aws-olm

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@oceanc80
Copy link
Contributor

oceanc80 commented Oct 11, 2022

/retest

@openshift-merge-robot openshift-merge-robot merged commit 6e37a87 into openshift:release-4.10 Oct 11, 2022
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 11, 2022

@timflannagan: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-1323 has been moved to the MODIFIED state.

Details

In response to this:

Signed-off-by: Daniel Sover [email protected]
Upstream-repository: operator-lifecycle-manager
Upstream-commit: dbd5b6f0d1dbc6981363c1345fa217629de97709

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@timflannagan timflannagan deleted the release-4.10-OCPBUGS-1323 branch October 11, 2022 20:16
@kuiwang02
Copy link
Contributor

kuiwang02 commented Oct 13, 2022

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Oct 13, 2022
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Jan 15, 2025
@camilamacedo86
Upgrade controller-gen v0.16.1 to v0.17.0 (openshift#392)
4bda73c 
Signed-off-by: Per Goncalves da Silva <[email protected]>
Upstream-repository: api
Upstream-commit: bd94d9759a9a21b1c8aeb0c1e735cf6ba50d40a8
@perdasilva perdasilva mentioned this pull request Jan 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@awgreene awgreene Awaiting requested review from awgreene

@joelanford joelanford Awaiting requested review from joelanford

@kuiwang02 kuiwang02 Awaiting requested review from kuiwang02

Assignees

@oceanc80 oceanc80

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@timflannagan @openshift-ci-robot @oceanc80 @bandrade @perdasilva @kuiwang02 @openshift-merge-robot @exdx