Skip to content

Default qps/burst to historical values#10926

Merged
openshift-bot merged 1 commit into
openshift:masterfrom
liggitt:default-qps
Sep 16, 2016
Merged

Default qps/burst to historical values#10926
openshift-bot merged 1 commit into
openshift:masterfrom
liggitt:default-qps

Conversation

@liggitt
Copy link
Copy Markdown
Contributor

@liggitt liggitt commented Sep 15, 2016 •
edited
Loading

Default empty qps/burst values to historical values

@liggitt
Copy link
Copy Markdown
Contributor Author

liggitt commented Sep 15, 2016

@smarterclayton @deads2k this would have prevented qos-gate

@liggitt liggitt added this to the 1.3.1 milestone Sep 15, 2016
@smarterclayton
Copy link
Copy Markdown
Contributor

smarterclayton commented Sep 15, 2016

QOS-gate - love it

@deads2k
Copy link
Copy Markdown
Contributor

deads2k commented Sep 15, 2016

QOS-gate - love it

I'm still bitter and I blame you! :)

@deads2k
Copy link
Copy Markdown
Contributor

deads2k commented Sep 15, 2016

lgtm. Surprised the fuzzer didn't need updating though.

@smarterclayton
Copy link
Copy Markdown
Contributor

smarterclayton commented Sep 15, 2016

Is it kwaz-gate or queue-oh-ess-gate?

On Thu, Sep 15, 2016 at 12:40 PM, David Eads notifications@github.com
wrote:

lgtm. Surprised the fuzzer didn't need updating though.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#10926 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABG_pzA6ioOm9iE3KW8k2pPub8OoldYBks5qqXUPgaJpZM4J9_38
.

@liggitt
Copy link
Copy Markdown
Contributor Author

liggitt commented Sep 15, 2016

[test]

@liggitt
Copy link
Copy Markdown
Contributor Author

liggitt commented Sep 15, 2016

Surprised the fuzzer didn't need updating though.

you can stop being surprised

@liggitt liggitt mentioned this pull request Sep 15, 2016
Merged
@liggitt liggitt removed this from the 1.3.1 milestone Sep 15, 2016
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Sep 16, 2016

Evaluated for origin test up to b03b653

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Sep 16, 2016

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/8905/)

@liggitt
Copy link
Copy Markdown
Contributor Author

liggitt commented Sep 16, 2016

[merge]

@liggitt liggitt added the lgtm Indicates that a PR is ready to be merged. label Sep 16, 2016
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Sep 16, 2016

Evaluated for origin merge up to b03b653

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Sep 16, 2016 •
edited
Loading

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/8916/) (Image: devenv-rhel7_5022)

@deads2k
Copy link
Copy Markdown
Contributor

deads2k commented Sep 16, 2016

you can stop being surprised

Good, that one worried me.

@openshift-bot openshift-bot merged commit 342f49c into openshift:master Sep 16, 2016
@liggitt liggitt deleted the default-qps branch September 16, 2016 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@liggitt @smarterclayton @deads2k @openshift-bot