Skip to content

UPSTREAM: 47731: Use endpoints informer for the endpoint controller. #15343

Closed
aveshagarwal wants to merge 3 commits into
openshift:release-3.6from
aveshagarwal:release-3.6-issue-14710
Closed

UPSTREAM: 47731: Use endpoints informer for the endpoint controller. #15343
aveshagarwal wants to merge 3 commits into
openshift:release-3.6from
aveshagarwal:release-3.6-issue-14710

Conversation

@aveshagarwal
Copy link
Copy Markdown
Contributor

@derekwaynecarr
Copy link
Copy Markdown
Member

[test]

FYI @smarterclayton @liggitt @eparis

@openshift-bot
Copy link
Copy Markdown
Contributor

Evaluated for origin test up to 4370d95

@openshift-bot
Copy link
Copy Markdown
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/3288/) (Base Commit: 12575c5) (PR Branch Commit: 4370d95)

1 similar comment
@openshift-bot
Copy link
Copy Markdown
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/3288/) (Base Commit: 12575c5) (PR Branch Commit: 4370d95)

@openshift-merge-robot openshift-merge-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 24, 2017
@aveshagarwal
Copy link
Copy Markdown
Contributor Author

@stevekuznetsov prow seems to be working extra hard on its first day, and insisting for approval every few minutes.

@aveshagarwal
Copy link
Copy Markdown
Contributor Author

As prow asked: /assign @smarterclayton

@stevekuznetsov
Copy link
Copy Markdown
Contributor

@aveshagarwal yeah, we found a bug in the approval code upstream -- considering a fix or rolling back that feature for now

@deads2k
Copy link
Copy Markdown
Contributor

deads2k commented Jul 25, 2017

/unassign

@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2017
@smarterclayton smarterclayton added this to the 3.6.x milestone Jul 28, 2017
@openshift-merge-robot openshift-merge-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2017
@openshift-merge-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aveshagarwal
We suggest the following additional approver: smarterclayton

Assign the PR to them by writing /assign @smarterclayton in a comment when ready.

Associated issue: 14710

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-merge-robot
Copy link
Copy Markdown
Contributor

@aveshagarwal PR needs rebase

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 15, 2017
@aveshagarwal
Copy link
Copy Markdown
Contributor Author

Its been taken care in #16575 so closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants