Skip to content

UPSTREAM: 59569: Do not ignore errors from EC2::DescribeVolume #18544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-robot merged 1 commit into from
Feb 9, 2018
Merged

UPSTREAM: 59569: Do not ignore errors from EC2::DescribeVolume #18544

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
UPSTREAM: 59569: Do not ignore errors from EC2::DescribeVolume in Det… 
…achDisk

The DetachDisk method of AWS cloudprovider indirectly calls
EC2::DescribeVolume AWS API function to check if the volume
being detached is really attached to the specified node.

The AWS API call may fail and return error which is logged however
the DetachDisk then finishes successfully. This may cause the AWS
volumes to remain attached to the instances forever because the
attach/detach controller will mark the volume as attached. The PV
controller will never be able to delete those disks and they need
to be detached manually.

This patch ensures on error from DescribeVolume is propagated to
attach/detach controller and the detach operation is re-tried.
  • Loading branch information
@tsmetana
tsmetana committed Feb 9, 2018
commit 15c1c88b6bef9a437fed960822f203f0620b9074
2 changes: 1 addition & 1 deletion vendor/k8s.io/kubernetes/pkg/cloudprovider/providers/aws/aws.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.