Skip to content

UPSTREAM: 66932: Include unavailable apiservices in discovery response - #20635

Merged
openshift-merge-robot merged 2 commits into
openshift:masterfrom
deads2k:server-16-agg503
Aug 16, 2018
Merged

UPSTREAM: 66932: Include unavailable apiservices in discovery response#20635
openshift-merge-robot merged 2 commits into
openshift:masterfrom
deads2k:server-16-agg503

Conversation

@deads2k

@deads2k deads2k commented Aug 14, 2018

Copy link
Copy Markdown
Contributor

This fixes GC behavior by providing 503s instead of 404s.

@openshift/sig-master

@openshift-ci-robot openshift-ci-robot added sig/master approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 14, 2018
@mfojtik

mfojtik commented Aug 14, 2018

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 14, 2018
@openshift-bot

openshift-bot commented Aug 14, 2018

Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@deads2k

deads2k commented Aug 14, 2018

Copy link
Copy Markdown
Contributor Author

/retest

2 similar comments
@deads2k

deads2k commented Aug 14, 2018

Copy link
Copy Markdown
Contributor Author

/retest

@deads2k

deads2k commented Aug 14, 2018

Copy link
Copy Markdown
Contributor Author

/retest

@openshift-bot

openshift-bot commented Aug 14, 2018

Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot

openshift-bot commented Aug 14, 2018

Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@deads2k

deads2k commented Aug 14, 2018

Copy link
Copy Markdown
Contributor Author

The partial discovery problem blocks this pull. Guess I'll be sorting that out in the controllers.

@openshift-bot

openshift-bot commented Aug 14, 2018

Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot

openshift-bot commented Aug 15, 2018

Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

openshift-bot commented Aug 15, 2018

Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

openshift-bot commented Aug 15, 2018

Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

openshift-bot commented Aug 15, 2018

Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot

openshift-bot commented Aug 15, 2018

Copy link
Copy Markdown
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Aug 15, 2018
@deads2k

deads2k commented Aug 15, 2018

Copy link
Copy Markdown
Contributor Author

/retest

2 similar comments
@deads2k

deads2k commented Aug 15, 2018

Copy link
Copy Markdown
Contributor Author

/retest

@deads2k

deads2k commented Aug 15, 2018

Copy link
Copy Markdown
Contributor Author

/retest

@sttts

sttts commented Aug 16, 2018

Copy link
Copy Markdown
Contributor

/retest
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 16, 2018
@openshift-ci-robot

openshift-ci-robot commented Aug 16, 2018

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, mfojtik, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot
openshift-merge-robot merged commit 8ca07b3 into openshift:master Aug 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liggitt liggitt Awaiting requested review from liggitt
@sttts sttts Awaiting requested review from sttts

Assignees

@mfojtik mfojtik

@sttts sttts

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. sig/master size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@deads2k @mfojtik @openshift-bot @sttts @openshift-ci-robot @openshift-merge-robot