Skip to content

Conversation

@deads2k
Copy link
Contributor

@deads2k deads2k commented Feb 20, 2019

  1. on create, only allow a whitelist of options
  2. on update, allow untouched fields to remain, but if they are touched, they are subject to normal validation
  3. on update, do not allow changing from techpreview to not techpreview
  4. ban all features.config.openshift.io deletion to prevent deletion and recreation without techpreview

/assign @derekwaynecarr

@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 20, 2019
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 20, 2019
@deads2k
Copy link
Contributor Author

deads2k commented Feb 20, 2019

/retest

@derekwaynecarr
Copy link
Member

the code looks good, but we should probably have a few unit tests.

@deads2k
Copy link
Contributor Author

deads2k commented Feb 20, 2019

the code looks good, but we should probably have a few unit tests.

sure

@deads2k deads2k added the lgtm Indicates that a PR is ready to be merged. label Feb 20, 2019
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@deads2k
Copy link
Contributor Author

deads2k commented Feb 20, 2019

/retest

1 similar comment
@deads2k
Copy link
Contributor Author

deads2k commented Feb 20, 2019

/retest

@deads2k
Copy link
Contributor Author

deads2k commented Feb 20, 2019

/lgtm

@openshift-ci-robot
Copy link

@deads2k: you cannot LGTM your own PR.

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants