Skip to content

Bug 1753500: UPSTREAM: 82503 #23934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Oct 14, 2019
Merged

Bug 1753500: UPSTREAM: 82503 #23934

openshift-merge-robot merged 1 commit into from
Oct 14, 2019

Conversation

@sallyom
Copy link
Contributor

@sallyom sallyom commented Oct 8, 2019

This is a manual pick of kubernetes/kubernetes#82503
Reorder symlinks to prevent path escapes

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 8, 2019

@sallyom: This pull request references Bugzilla bug 1753500, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Bug 1753500: UPSTREAM: 82503

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 8, 2019
@sallyom
Copy link
Contributor Author

sallyom commented Oct 8, 2019

/assign @soltysh

soltysh
soltysh approved these changes Oct 8, 2019
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 8, 2019
@sallyom
Copy link
Contributor Author

sallyom commented Oct 9, 2019

/retest

@sallyom
UPSTREAM: 82503: Bug 1753500
1e6383a 
This is a manual pick of kubernetes/kubernetes#82503
Reorder symlinks to prevent path escapes
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 9, 2019
soltysh
soltysh approved these changes Oct 9, 2019
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 9, 2019
@mfojtik
Copy link
Contributor

mfojtik commented Oct 14, 2019

/approve

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 14, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mfojtik, sallyom, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 14, 2019
@mrunalp mrunalp added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Oct 14, 2019
@openshift-bot
Copy link
Contributor

openshift-bot commented Oct 14, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 5ecef40 into openshift:release-4.1 Oct 14, 2019
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 14, 2019

@sallyom: All pull requests linked via external trackers have merged. Bugzilla bug 1753500 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1753500: UPSTREAM: 82503

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bparees bparees Awaiting requested review from bparees

@sjenning sjenning Awaiting requested review from sjenning

1 more reviewer

@soltysh soltysh soltysh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@soltysh soltysh

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@sallyom @openshift-ci-robot @mfojtik @openshift-bot @soltysh @mrunalp @openshift-merge-robot