-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Bug 1771809: add PodDisruptionBudgetAtLimit alert e2e #24169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@sallyom: This pull request references Bugzilla bug 1771809, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sallyom The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Failing bc alert is 'pending' not 'firing' -via slack discussion it's ok to check for 'pending' alert, since it will be pending for 15min. Now, have to figure out best place for this test (best place is not here where I've put it, but conveniently the extended/prometheus has set up testing alerts w/ queries already so was convenient place to start). |
| exutil "github.com/openshift/origin/test/extended/util" | ||
| ) | ||
|
|
||
| var _ = g.Describe("[Feature:PodDisruptionBudgetAtLimitAlert][Conformance] Prometheus", func() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is so if/when this test fails cluster-kube-controller-manager-operator (API/Workloads) peeps might get the bug/issue rather than monitoring folks.
I've created a new file test/extended/prometheus/alerts.go and have included all necessary fns to make the query in one file test/extended/prometheus/util.go, so anyone else wanting to check on a pending alert might find them. |
|
@sallyom: This pull request references Bugzilla bug 1771809, which is valid. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
|
closing in favor of openshift/cluster-kube-controller-manager-operator#316, openshift/library-go#602 |
|
@sallyom: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
test for PodDisruptionBudgetAtLimit Alert fires when a PodDisruptionBudget with MinAvailable is created.
see also: openshift/cluster-kube-controller-manager-operator#316
https://bugzilla.redhat.com/show_bug.cgi?id=1771809#c1
/cc @soltysh