Skip to content

Conversation

@sallyom
Copy link
Contributor

@sallyom sallyom commented Nov 19, 2019

test for PodDisruptionBudgetAtLimit Alert fires when a PodDisruptionBudget with MinAvailable is created.

see also: openshift/cluster-kube-controller-manager-operator#316
https://bugzilla.redhat.com/show_bug.cgi?id=1771809#c1
/cc @soltysh

@openshift-ci-robot
Copy link

@sallyom: This pull request references Bugzilla bug 1771809, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Bug 1771809: add PodDisruptionBudget e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 19, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sallyom
To complete the pull request process, please assign adambkaplan
You can assign the PR to them by writing /assign @adambkaplan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sallyom
Copy link
Contributor Author

sallyom commented Nov 19, 2019

Failing bc alert is 'pending' not 'firing' -via slack discussion it's ok to check for 'pending' alert, since it will be pending for 15min. Now, have to figure out best place for this test (best place is not here where I've put it, but conveniently the extended/prometheus has set up testing alerts w/ queries already so was convenient place to start).

@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 19, 2019
exutil "github.com/openshift/origin/test/extended/util"
)

var _ = g.Describe("[Feature:PodDisruptionBudgetAtLimitAlert][Conformance] Prometheus", func() {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is so if/when this test fails cluster-kube-controller-manager-operator (API/Workloads) peeps might get the bug/issue rather than monitoring folks.

@sallyom
Copy link
Contributor Author

sallyom commented Nov 19, 2019

Now, have to figure out best place for this test

I've created a new file test/extended/prometheus/alerts.go and have included all necessary fns to make the query in one file test/extended/prometheus/util.go, so anyone else wanting to check on a pending alert might find them.
I don't believe the 'pending' alert will interfere with the current check that no alerts are 'firing' other than Watchdog alert, since the alert will remain pending for 15 min, and as soon as the test completes (as soon as the alert is 'pending') the pod/ns is deleted.

@sallyom sallyom changed the title Bug 1771809: add PodDisruptionBudget e2e Bug 1771809: add PodDisruptionBudgetAtLimit alert e2e Nov 19, 2019
@openshift-ci-robot
Copy link

@sallyom: This pull request references Bugzilla bug 1771809, which is valid.

Details

In response to this:

Bug 1771809: add PodDisruptionBudgetAtLimit alert e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sallyom
Copy link
Contributor Author

sallyom commented Nov 21, 2019

/retest

@sallyom
Copy link
Contributor Author

sallyom commented Nov 25, 2019

@sallyom sallyom closed this Nov 25, 2019
@openshift-ci-robot
Copy link

@sallyom: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants