Skip to content

[release-3.11] Bug 1769952: React to openshift/ruby-hello-world change #24189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Nov 25, 2019
Merged

[release-3.11] Bug 1769952: React to openshift/ruby-hello-world change #24189

openshift-merge-robot merged 1 commit into from
Nov 25, 2019

Conversation

@adambkaplan
Copy link
Contributor

@adambkaplan adambkaplan commented Nov 21, 2019

Update build, cmd, and integration tests to use centos/ruby-25-centos7 image

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 21, 2019
@adambkaplan adambkaplan mentioned this pull request Nov 21, 2019
Closed
@openshift-ci-robot openshift-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 21, 2019
@akram akram mentioned this pull request Nov 22, 2019
Closed
@adambkaplan
[release-3.11] Bug 1769952: React to openshift/ruby-hello-world changes
722f39b 
Update build, cmd, and integration tests to use centos/ruby-25-centos7 image
@adambkaplan adambkaplan changed the title WIP - [release-3.11] Fix origin tests [release-3.11] Fix origin tests Nov 22, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 22, 2019
@adambkaplan adambkaplan changed the title [release-3.11] Fix origin tests [release-3.11] Bug 1769952: React to openshift/ruby-hello-world change Nov 22, 2019
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 22, 2019

@adambkaplan: This pull request references Bugzilla bug 1769952, which is invalid:

  • expected dependent Bugzilla bug 1769951 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[release-3.11] Bug 1769952: React to openshift/ruby-hello-world change

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Nov 22, 2019
@adambkaplan
Copy link
Contributor Author

adambkaplan commented Nov 22, 2019

/assign @bparees

We had a green run before I squashed.

@bparees
Copy link
Contributor

bparees commented Nov 22, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 22, 2019
@bparees
Copy link
Contributor

bparees commented Nov 22, 2019

/approve

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 22, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, bparees

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@akram
Copy link
Contributor

akram commented Nov 25, 2019 •
edited
Loading

The dependent bug is still in the POST state.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 25, 2019

@akram: This pull request references Bugzilla bug 1769952, which is invalid:

  • expected dependent Bugzilla bug 1769951 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@adambkaplan
Copy link
Contributor Author

adambkaplan commented Nov 25, 2019

@akram looks like the BZ bots got confused a bit. 4.1 bug is in MODIFIED state now.

@bparees
Copy link
Contributor

bparees commented Nov 25, 2019

/bugzilla override

almost entirely non-shipping file changes and this is blocking critical delivery of other PRs. Only shippping change is a minor text/help output change.

@bparees bparees added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Nov 25, 2019
@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 25, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 25, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@sallyom sallyom mentioned this pull request Nov 25, 2019
Merged
@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 25, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 25, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 1f475a8 into openshift:release-3.11 Nov 25, 2019
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 25, 2019

@adambkaplan: All pull requests linked via external trackers have merged. Bugzilla bug 1769952 has been moved to the MODIFIED state.

Details

In response to this:

[release-3.11] Bug 1769952: React to openshift/ruby-hello-world change

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dcbw dcbw Awaiting requested review from dcbw

@ironcladlou ironcladlou Awaiting requested review from ironcladlou

Assignees

@bparees bparees

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@adambkaplan @openshift-ci-robot @bparees @akram @openshift-bot @openshift-merge-robot