Skip to content

Conversation

@marun
Copy link
Contributor

@marun marun commented Jul 1, 2021

No description provided.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 1, 2021

@marun: This pull request references Bugzilla bug 1977383, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.z) matches configured target release for branch (4.7.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1946479 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 1946479 targets the "4.8.0" release, which is one of the valid target releases: 4.8.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla ([email protected]), skipping review request.

Details

In response to this:

Bug 1977383: Update resource quota test for compatibility with service ca configmap publishing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jul 1, 2021
@openshift-ci openshift-ci bot requested review from bparees and sjenning July 1, 2021 17:51
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 1, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: marun
To complete the pull request process, please assign pweil- after the PR has been reviewed.
You can assign the PR to them by writing /assign @pweil- in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the vendor-update Touching vendor dir or related files label Jul 1, 2021
@marun marun changed the title Bug 1977383: Update resource quota test for compatibility with service ca configmap publishing Bug 1977383: [release-4.7] Update resource quota test for compatibility with service ca configmap publishing Jul 1, 2021
@marun
Copy link
Contributor Author

marun commented Jul 1, 2021

/retest

@marun
Copy link
Contributor Author

marun commented Jul 1, 2021

/retest

serial job is failing on aws infra issue unrelated to this PR.

@marun
Copy link
Contributor Author

marun commented Jul 1, 2021

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 2, 2021

@marun: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/artifacts e7faef5 link /test artifacts
ci/prow/e2e-aws-serial e7faef5 link /test e2e-aws-serial

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@marun marun changed the title Bug 1977383: [release-4.7] Update resource quota test for compatibility with service ca configmap publishing WIP Bug 1977383: [release-4.7] Update resource quota test for compatibility with service ca configmap publishing Jul 2, 2021
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 2, 2021
@marun
Copy link
Contributor Author

marun commented Jul 2, 2021

Marking WIP until openshift/kubernetes#843 merges and this PR is updated to incorporate it. The quota and watch fixes are both required to merge to [email protected] before openshift/kubernetes#834 can safely merge.

@s-urbaniak
Copy link
Contributor

/close
exactly this bump just merged as part of #26259

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 2, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 2, 2021

@marun: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 2, 2021

@s-urbaniak: Closed this PR.

Details

In response to this:

/close
exactly this bump just merged as part of #26259

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot closed this Jul 2, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 2, 2021

@marun: This pull request references Bugzilla bug 1977383. The bug has been updated to no longer refer to the pull request using the external bug tracker.

Details

In response to this:

WIP Bug 1977383: [release-4.7] Update resource quota test for compatibility with service ca configmap publishing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. vendor-update Touching vendor dir or related files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants