-
Notifications
You must be signed in to change notification settings - Fork 4.8k
ETCD-674: Add E2E test for scaling when an unhealthy member is present #29203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ETCD-674: Add E2E test for scaling when an unhealthy member is present #29203
Conversation
|
@jubittajohn: This pull request references ETCD-674 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jubittajohn The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test e2e-aws-ovn-etcd-scaling |
97d7498 to
fdbfada
Compare
|
/test e2e-aws-ovn-etcd-scaling |
|
@jubittajohn: This pull request references ETCD-674 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/test e2e-aws-ovn-etcd-scaling |
|
Job Failure Risk Analysis for sha: 34733b4
|
0cd8930 to
5c2b0d3
Compare
|
/test e2e-aws-ovn-etcd-scaling |
|
Job Failure Risk Analysis for sha: 5c2b0d3
|
7028ca9 to
b5520ee
Compare
|
/test e2e-aws-ovn-etcd-scaling |
|
Job Failure Risk Analysis for sha: b5520ee
|
28a3d90 to
eee774f
Compare
eee774f to
5d2c0c7
Compare
|
/test e2e-aws-ovn-etcd-scaling |
|
|
||
| import ( | ||
| "fmt" | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you run make verify? Not sure what's up with this.
FAILURE after 1.054s: hack/verify-generated.sh:14: executing 'git diff --exit-code /go/src/github.com/openshift/origin/test/extended/util/annotate/generated/' expecting success: the command returned the wrong error code
Standard output from the command:
diff --git a/test/extended/util/annotate/generated/zz_generated.annotations.go b/test/extended/util/annotate/generated/zz_generated.annotations.go
index 3f99baec7a..dbd41569a8 100644
--- a/test/extended/util/annotate/generated/zz_generated.annotations.go
+++ b/test/extended/util/annotate/generated/zz_generated.annotations.go
@@ -2,7 +2,6 @@ package generated
import (
"fmt"
-
"github.com/onsi/ginkgo/v2"
"github.com/onsi/ginkgo/v2/types"
)
|
Job Failure Risk Analysis for sha: 5d2c0c7
|
f4dae15 to
da504c1
Compare
|
/test e2e-aws-ovn-etcd-scaling |
|
Job Failure Risk Analysis for sha: da504c1
|
9ef1128 to
a9cb8f4
Compare
a9cb8f4 to
e240756
Compare
|
/test e2e-aws-ovn-etcd-scaling |
|
/test e2e-gcp-ovn-etcd-scaling |
|
/test e2e-aws-ovn-etcd-scaling |
|
Job Failure Risk Analysis for sha: e240756
|
6462803 to
c85351e
Compare
|
/test e2e-aws-ovn-etcd-scaling |
|
Job Failure Risk Analysis for sha: c85351e
|
Signed-off-by: jubittajohn <[email protected]>
c85351e to
723212b
Compare
|
/test e2e-aws-ovn-etcd-scaling |
|
@jubittajohn: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Job Failure Risk Analysis for sha: 723212b
|
|
Added this test to the PR: #29236 |
The following test covers a vertical scaling scenario when a member is unhealthy.This test validates that scale down happens before scale up if the deleted member is unhealthy.CPMS is disabled to observe that scale-down happens first in this case.