Skip to content

Conversation

@ibihim
Copy link
Contributor

@ibihim ibihim commented May 15, 2025

What

Add tests that the setting of the minimally sufficient PodSecurityStandard annotation works

Why

Because we want to protect the feature from breaking.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 15, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 15, 2025

@ibihim: This pull request references CNTRLPLANE-55 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

Details

In response to this:

What

Add tests that the setting of the minimally sufficient PodSecurityStandard annotation works

Why

Because we want to protect the feature from breaking.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from liouk and p0lyn0mial May 15, 2025 15:48
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 15, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ibihim
Once this PR has been reviewed and has the lgtm label, please assign neisw for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-trt
Copy link

openshift-trt bot commented May 15, 2025

Risk analysis has seen new tests most likely introduced by this PR.
Please ensure that new tests meet guidelines for naming and stability.

New tests seen in this PR at sha: 77b723b

  • "[sig-auth][Feature:PodSecurity] with baseline level should set correct MinimallySufficientPodSecurityStandard, even though PSA label is set to Baseline [Suite:openshift/conformance/parallel]" [Total: 21, Pass: 21, Fail: 0, Flake: 1]
  • "[sig-auth][Feature:PodSecurity] with restricted level restricted-v2 SCC should mutate empty securityContext to match restricted PSa profile [Suite:openshift/conformance/parallel]" [Total: 21, Pass: 21, Fail: 0, Flake: 0]

@ibihim
Copy link
Contributor Author

ibihim commented May 16, 2025

/retest-required

2 similar comments
@ibihim
Copy link
Contributor Author

ibihim commented May 19, 2025

/retest-required

@ibihim
Copy link
Contributor Author

ibihim commented Jul 23, 2025

/retest-required

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 3, 2025
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 18, 2025

@ibihim: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-serial-publicnet 77b723b link false /test e2e-aws-ovn-serial-publicnet
ci/prow/e2e-gcp-disruptive 77b723b link false /test e2e-gcp-disruptive
ci/prow/e2e-aws-ovn-single-node-serial 77b723b link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-vsphere-ovn-etcd-scaling 77b723b link false /test e2e-vsphere-ovn-etcd-scaling
ci/prow/4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade-rollback 77b723b link false /test 4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade-rollback
ci/prow/okd-e2e-gcp 77b723b link false /test okd-e2e-gcp
ci/prow/e2e-aws-disruptive 77b723b link false /test e2e-aws-disruptive
ci/prow/e2e-metal-ipi-serial-ovn-ipv6 77b723b link false /test e2e-metal-ipi-serial-ovn-ipv6
ci/prow/e2e-aws-ovn-etcd-scaling 77b723b link false /test e2e-aws-ovn-etcd-scaling
ci/prow/e2e-gcp-fips-serial 77b723b link false /test e2e-gcp-fips-serial
ci/prow/e2e-aws-ovn-single-node 77b723b link false /test e2e-aws-ovn-single-node
ci/prow/e2e-vsphere-ovn-dualstack-primaryv6 77b723b link false /test e2e-vsphere-ovn-dualstack-primaryv6
ci/prow/e2e-azure-ovn-upgrade 77b723b link false /test e2e-azure-ovn-upgrade
ci/prow/e2e-gcp-ovn-etcd-scaling 77b723b link false /test e2e-gcp-ovn-etcd-scaling
ci/prow/e2e-openstack-serial 77b723b link false /test e2e-openstack-serial
ci/prow/e2e-azure-ovn-etcd-scaling 77b723b link false /test e2e-azure-ovn-etcd-scaling
ci/prow/e2e-gcp-csi 77b723b link true /test e2e-gcp-csi
ci/prow/e2e-aws-csi 77b723b link true /test e2e-aws-csi
ci/prow/go-verify-deps 77b723b link true /test go-verify-deps
ci/prow/e2e-aws-ovn-microshift-serial 77b723b link true /test e2e-aws-ovn-microshift-serial
ci/prow/e2e-aws-ovn-microshift 77b723b link true /test e2e-aws-ovn-microshift
ci/prow/e2e-metal-ipi-ovn-ipv6 77b723b link true /test e2e-metal-ipi-ovn-ipv6

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants