[WIP] DRA e2e test to validate Nvidia gpu #29842
Open
+101,364
−93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Job Failure Risk Analysis for sha: 65c8551
Showing 20 of 50 jobs analysis |
|
Job Failure Risk Analysis for sha: 1a35f9b
Showing 20 of 51 jobs analysis |
openshift-merge-robot
added
the
needs-rebase
|
Job Failure Risk Analysis for sha: 3ff31f3
Showing 20 of 50 jobs analysis |
tkashem
force-pushed
the
dra-test
branch
2 times, most recently
from
f8a3b41 to
54228d4
Compare
|
Job Failure Risk Analysis for sha: 54228d4
Showing 20 of 52 jobs analysis |
|
Job Failure Risk Analysis for sha: a82f7b5
Showing 20 of 52 jobs analysis |
|
Job Failure Risk Analysis for sha: 208156b
Showing 20 of 52 jobs analysis |
|
Job Failure Risk Analysis for sha: ef7d781
Showing 20 of 52 jobs analysis |
|
Job Failure Risk Analysis for sha: 10cfb98
Showing 20 of 52 jobs analysis |
|
Job Failure Risk Analysis for sha: bfb134e
Showing 20 of 52 jobs analysis |
tkashem
force-pushed
the
dra-test
branch
2 times, most recently
from
38d9d4d to
d738313
Compare
|
Job Failure Risk Analysis for sha: d738313
Showing 20 of 52 jobs analysis |
|
Job Failure Risk Analysis for sha: cc12c35
Showing 20 of 52 jobs analysis |
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: harche, tkashem The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kannon92
reviewed
Sep 17, 2025
test/extended/dra/common_spec.go
Outdated
| helper "github.com/openshift/origin/test/extended/dra/helper" | ||
|
|
||
| corev1 "k8s.io/api/core/v1" | ||
| resourceapi "k8s.io/api/resource/v1beta1" |
Contributor
There was a problem hiding this comment.
kubernetes-sigs/kueue#5873 (comment)
I still think we should use v1beta2 rather than v1beta1.
I was told that DRA community broke the API in v1beta and they are roundtripping v1beta2 to v1.
Contributor
Author
There was a problem hiding this comment.
the test suite (client) can use v1beta1, or v1beta2 as long as the api version is being served. also, if we want this suite to run against 4.19 cluster v1beta1 is the only option
openshift-ci
bot
added
do-not-merge/hold
openshift-merge-robot
added
the
needs-rebase
|
Job Failure Risk Analysis for sha: dad20be
|
- use helm.sh/helm/v3 v3.18.0 - pin to the current version of github.com/distribution/distribution/v3 being used
openshift-merge-robot
removed
the
needs-rebase
Contributor
|
New changes are detected. LGTM label has been removed. |
|
Risk analysis has seen new tests most likely introduced by this PR. New Test Risks for sha: 94c485b
New tests seen in this PR at sha: 94c485b
|
1 similar comment
|
Risk analysis has seen new tests most likely introduced by this PR. New Test Risks for sha: 94c485b
New tests seen in this PR at sha: 94c485b
|
This was referenced Nov 19, 2025
Switch DRA beta API to v1
Contributor
|
@tkashem: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.