Skip to content

Conversation

@mdbooth
Copy link
Contributor

@mdbooth mdbooth commented Jul 7, 2025

Go 1.24 requires format strings to be string constants.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 7, 2025
@openshift-ci-robot
Copy link

@mdbooth: This pull request explicitly references no jira issue.

Details

In response to this:

Go 1.24 requires format strings to be string constants.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from alebedev87 and anik120 July 7, 2025 18:43
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 7, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mdbooth
Once this PR has been reviewed and has the lgtm label, please assign dgoodwin for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Go 1.24 requires format strings to be string constants.
@mdbooth
Copy link
Contributor Author

mdbooth commented Jul 7, 2025

The lint errors are wrong. In the past I've found these problems normally go away when I bump golanci-lint. However, the newest golangci-lint image we have is built against Go 1.23, so we can't use it with Go 1.24:

https://github.com/openshift/release/blob/8f06238188359fa692b5e270e3d16aafaefc7034/core-services/image-mirroring/_config.yaml#L836-L837

@mdbooth
Copy link
Contributor Author

mdbooth commented Jul 9, 2025

/test lint

@mdbooth
Copy link
Contributor Author

mdbooth commented Jul 18, 2025

/retest-required

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 3, 2025
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 18, 2025

@mdbooth: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-fips-serial-1of2 ddfd8ae link false /test e2e-gcp-fips-serial-1of2
ci/prow/e2e-openstack-ovn ddfd8ae link false /test e2e-openstack-ovn
ci/prow/e2e-azure-ovn-etcd-scaling ddfd8ae link false /test e2e-azure-ovn-etcd-scaling
ci/prow/e2e-aws-ovn-serial-publicnet-1of2 ddfd8ae link false /test e2e-aws-ovn-serial-publicnet-1of2
ci/prow/e2e-vsphere-ovn-etcd-scaling ddfd8ae link false /test e2e-vsphere-ovn-etcd-scaling
ci/prow/e2e-aws-ovn-cgroupsv2 ddfd8ae link false /test e2e-aws-ovn-cgroupsv2
ci/prow/e2e-openstack-serial ddfd8ae link false /test e2e-openstack-serial
ci/prow/okd-e2e-gcp ddfd8ae link false /test okd-e2e-gcp
ci/prow/e2e-metal-ipi-serial-ovn-ipv6-2of2 ddfd8ae link false /test e2e-metal-ipi-serial-ovn-ipv6-2of2
ci/prow/e2e-gcp-disruptive ddfd8ae link false /test e2e-gcp-disruptive
ci/prow/e2e-aws-ovn-etcd-scaling ddfd8ae link false /test e2e-aws-ovn-etcd-scaling
ci/prow/e2e-gcp-ovn-etcd-scaling ddfd8ae link false /test e2e-gcp-ovn-etcd-scaling
ci/prow/e2e-azure-ovn-upgrade ddfd8ae link false /test e2e-azure-ovn-upgrade
ci/prow/e2e-aws-ovn-upgrade-rollback ddfd8ae link false /test e2e-aws-ovn-upgrade-rollback
ci/prow/e2e-aws-ovn-single-node ddfd8ae link false /test e2e-aws-ovn-single-node
ci/prow/e2e-agnostic-ovn-cmd ddfd8ae link false /test e2e-agnostic-ovn-cmd
ci/prow/e2e-vsphere-ovn-dualstack-primaryv6 ddfd8ae link false /test e2e-vsphere-ovn-dualstack-primaryv6
ci/prow/e2e-aws-ovn-single-node-upgrade ddfd8ae link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-gcp-fips-serial-2of2 ddfd8ae link false /test e2e-gcp-fips-serial-2of2
ci/prow/e2e-aws-disruptive ddfd8ae link false /test e2e-aws-disruptive
ci/prow/e2e-gcp-csi ddfd8ae link true /test e2e-gcp-csi
ci/prow/e2e-aws-csi ddfd8ae link true /test e2e-aws-csi
ci/prow/go-verify-deps ddfd8ae link true /test go-verify-deps
ci/prow/e2e-aws-ovn-microshift ddfd8ae link true /test e2e-aws-ovn-microshift
ci/prow/e2e-aws-ovn-microshift-serial ddfd8ae link true /test e2e-aws-ovn-microshift-serial
ci/prow/e2e-metal-ipi-ovn-ipv6 ddfd8ae link true /test e2e-metal-ipi-ovn-ipv6

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants