Skip to content

NO-JIRA: Ensure Platform Prometheus targets are protected #30014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 7 commits into from
Aug 14, 2025
Merged

NO-JIRA: Ensure Platform Prometheus targets are protected #30014

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
301fda3
Ensure Platform Prometheus targets are protected
hongkailiu Jul 23, 2025
ec95d6e
make update
hongkailiu Jul 29, 2025
834c597
Skip if openshift-monitoring namespace does not exist
hongkailiu Aug 13, 2025
de9d258
Reduce timeout of retry to 1m from 5m
hongkailiu Aug 13, 2025
6de93bb
Update test/extended/prometheus/prometheus.go
hongkailiu Aug 14, 2025
1957643
Update test/extended/prometheus/prometheus.go
hongkailiu Aug 14, 2025
90a26ea
Update test/extended/prometheus/prometheus.go
hongkailiu Aug 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update test/extended/prometheus/prometheus.go 
Co-authored-by: Simon Pasquier <[email protected]>
  • Loading branch information
@hongkailiu @simonpasquier
hongkailiu and simonpasquier authored Aug 14, 2025
commit 6de93bb3ead9f8cb1b07c74d7da864dafdc7dd62
2 changes: 1 addition & 1 deletion test/extended/prometheus/prometheus.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ var _ = g.Describe("[sig-instrumentation][Late] Platform Prometheus targets", fu
continue
}
pod := target.Labels["pod"]
e2e.Logf("Checking via pod exec status code from the scaple url %s for pod %s/%s without authorization (skip=%t)", target.ScrapeUrl, ns, pod, namespacesToSkip.Has(ns))
e2e.Logf("Checking via pod exec status code from the scrape url %s for pod %s/%s without authorization (skip=%t)", target.ScrapeUrl, ns, pod, namespacesToSkip.Has(ns))
err := wait.PollUntilContextTimeout(context.Background(), 10*time.Second, time.Minute, true, func(context.Context) (bool, error) {
statusCode, execError := helper.URLStatusCodeExecViaPod(execPod.Namespace, execPod.Name, target.ScrapeUrl)
e2e.Logf("The scaple url %s for pod %s/%s without authorization returned %d, %v (skip=%t)", target.ScrapeUrl, ns, pod, statusCode, execError, namespacesToSkip.Has(ns))
Expand Down