Skip to content

NO-JIRA: Stop setting feature gate conditional #30146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 1 commit into from
Aug 28, 2025
Merged

NO-JIRA: Stop setting feature gate conditional #30146

openshift-merge-bot merged 1 commit into from
Aug 28, 2025

Conversation

@petr-muller
Copy link
Member

@petr-muller petr-muller commented Aug 21, 2025

openshift/oc#2063 promoted oc adm upgrade status and removed the conditional check of the OC_ENABLE_CMD_UPGRADE_STATUS envvar, so the tests should no longer set it either.

@petr-muller
OTA-1581: Stop setting feature gate conditional
6dfc2c5 
openshift/oc#2063 promoted `oc adm upgrade status` and removed the conditional check of the `OC_ENABLE_CMD_UPGRADE_STATUS` envvar, so the tests should no longer set it either.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 21, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 21, 2025 •
edited by openshift-ci bot
Loading

@petr-muller: This pull request references OTA-1581 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set.

Details

In response to this:

openshift/oc#2063 promoted oc adm upgrade status and removed the conditional check of the OC_ENABLE_CMD_UPGRADE_STATUS envvar, so the tests should no longer set it either.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 21, 2025
@hongkailiu
Copy link
Member

hongkailiu commented Aug 21, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 21, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongkailiu, petr-muller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@petr-muller
Copy link
Member Author

petr-muller commented Aug 21, 2025

/hold

I'll want to inspect the results to be sure

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 21, 2025
@petr-muller
Copy link
Member Author

petr-muller commented Aug 21, 2025

/retest

@petr-muller
Copy link
Member Author

petr-muller commented Aug 25, 2025

I have inspected the jobs, the tests continue to work as expected

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 25, 2025
@petr-muller
Copy link
Member Author

petr-muller commented Aug 25, 2025

/retest-required

@petr-muller
Copy link
Member Author

petr-muller commented Aug 25, 2025

/label acknowledge-critical-fixes-only

@petr-muller
Copy link
Member Author

petr-muller commented Aug 25, 2025

/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Aug 25, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 25, 2025

/retest-required

Remaining retests: 0 against base HEAD cc8ae10 and 2 for PR HEAD 6dfc2c5 in total

@petr-muller
Copy link
Member Author

petr-muller commented Aug 26, 2025

/retest-required

@petr-muller petr-muller changed the title OTA-1581: Stop setting feature gate conditional NO-JIRA: Stop setting feature gate conditional Aug 26, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 26, 2025

@petr-muller: This pull request explicitly references no jira issue.

Details

In response to this:

openshift/oc#2063 promoted oc adm upgrade status and removed the conditional check of the OC_ENABLE_CMD_UPGRADE_STATUS envvar, so the tests should no longer set it either.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 26, 2025

/retest-required

Remaining retests: 0 against base HEAD e7b4f7e and 2 for PR HEAD 6dfc2c5 in total

1 similar comment
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 26, 2025

/retest-required

Remaining retests: 0 against base HEAD e7b4f7e and 2 for PR HEAD 6dfc2c5 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 26, 2025 •
edited
Loading

@petr-muller: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node 6dfc2c5 link false /test e2e-aws-ovn-single-node
ci/prow/e2e-aws-ovn-single-node-upgrade 6dfc2c5 link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-aws-ovn-kube-apiserver-rollout 6dfc2c5 link false /test e2e-aws-ovn-kube-apiserver-rollout
ci/prow/e2e-aws-ovn-edge-zones 6dfc2c5 link false /test e2e-aws-ovn-edge-zones
ci/prow/e2e-openstack-ovn 6dfc2c5 link false /test e2e-openstack-ovn
ci/prow/e2e-gcp-ovn-techpreview-serial-2of2 6dfc2c5 link false /test e2e-gcp-ovn-techpreview-serial-2of2
ci/prow/e2e-gcp-ovn-techpreview 6dfc2c5 link false /test e2e-gcp-ovn-techpreview
ci/prow/e2e-gcp-csi 6dfc2c5 link false /test e2e-gcp-csi
ci/prow/e2e-aws-disruptive 6dfc2c5 link false /test e2e-aws-disruptive
ci/prow/e2e-azure 6dfc2c5 link false /test e2e-azure
ci/prow/e2e-metal-ipi-serial-ovn-ipv6-1of2 6dfc2c5 link false /test e2e-metal-ipi-serial-ovn-ipv6-1of2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-trt
Copy link

openshift-trt bot commented Aug 26, 2025

Job Failure Risk Analysis for sha: 6dfc2c5

Job Name Failure Risk
pull-ci-openshift-origin-main-e2e-metal-ipi-ovn-ipv6 IncompleteTests
Tests for this run (104) are below the historical average (2257): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 27, 2025

/retest-required

Remaining retests: 0 against base HEAD e7b4f7e and 2 for PR HEAD 6dfc2c5 in total

@openshift-merge-bot openshift-merge-bot bot merged commit 180d880 into openshift:main Aug 28, 2025
26 of 47 checks passed
@petr-muller petr-muller deleted the ota-1581-remove-envvar-conditionals branch August 28, 2025 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DavidHurta DavidHurta Awaiting requested review from DavidHurta

@hongkailiu hongkailiu Awaiting requested review from hongkailiu

Assignees

@hongkailiu hongkailiu

Labels

acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@petr-muller @openshift-ci-robot @hongkailiu