OTA-1626: fail CI if any ClusterOperator takes too long to update #30269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hongkailiu: This pull request references OTA-1626 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
hongkailiu
changed the title
openshift-ci
bot
added
the
do-not-merge/work-in-progress
hongkailiu
force-pushed
the
OTA-1626
branch
2 times, most recently
from
f251ec2 to
8d5bda7
Compare
|
Job Failure Risk Analysis for sha: 8d5bda7
Risk analysis has seen new tests most likely introduced by this PR. New tests seen in this PR at sha: 8d5bda7
|
hongkailiu
force-pushed
the
OTA-1626
branch
from
8d5bda7 to
9676d29
Compare
|
@hongkailiu: This pull request references OTA-1626 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Member
Author
|
Just found this beautiful thing. I guess we could also access the data there to fail the cases.
Con:
PS. 
|
hongkailiu
force-pushed
the
OTA-1626
branch
from
9676d29 to
299fe10
Compare
|
@hongkailiu: This pull request references OTA-1626 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
hongkailiu
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
hongkailiu
commented
Sep 18, 2025
pkg/monitortests/clusterversionoperator/clusterversionchecker/monitortest.go
Outdated
Show resolved
Hide resolved
|
Job Failure Risk Analysis for sha: 299fe10
Risk analysis has seen new tests most likely introduced by this PR. New tests seen in this PR at sha: 299fe10
|
Member
|
/cc |
wking
reviewed
Sep 19, 2025
pkg/monitortests/clusterversionoperator/clusterversionchecker/monitortest.go
Outdated
Show resolved
Hide resolved
wking
reviewed
Sep 19, 2025
pkg/monitortests/clusterversionoperator/clusterversionchecker/monitortest.go
Outdated
Show resolved
Hide resolved
wking
reviewed
Sep 19, 2025
pkg/monitortests/clusterversionoperator/clusterversionchecker/monitortest.go
Outdated
Show resolved
Hide resolved
hongkailiu
force-pushed
the
OTA-1626
branch
from
299fe10 to
c4e513f
Compare
petr-muller
reviewed
Sep 19, 2025
pkg/monitortests/clusterversionoperator/clusterversionchecker/monitortest.go
Outdated
Show resolved
Hide resolved
pkg/monitortests/clusterversionoperator/clusterversionchecker/monitortest.go
Outdated
Show resolved
Hide resolved
hongkailiu
force-pushed
the
OTA-1626
branch
from
c4e513f to
65071a0
Compare
openshift-ci
bot
added
the
do-not-merge/hold
hongkailiu
force-pushed
the
OTA-1626
branch
from
65071a0 to
6801245
Compare
hongkailiu
changed the title
hongkailiu
force-pushed
the
OTA-1626
branch
from
6801245 to
67efa89
Compare
Member
Author
|
/retest-required |
|
Risk analysis has seen new tests most likely introduced by this PR. New Test Risks for sha: 677c97e
New tests seen in this PR at sha: 677c97e
|
|
Risk analysis has seen new tests most likely introduced by this PR. New Test Risks for sha: 677c97e
New tests seen in this PR at sha: 677c97e
|
|
/hold Revision 677c97e was retested 3 times: holding |
openshift-ci
bot
added
the
do-not-merge/hold
|
Job Failure Risk Analysis for sha: 677c97e
Risk analysis has seen new tests most likely introduced by this PR. New Test Risks for sha: 677c97e
New tests seen in this PR at sha: 677c97e
|
Member
Author
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
Member
Author
|
/test e2e-gcp-ovn-upgrade |
|
Job Failure Risk Analysis for sha: 677c97e
Risk analysis has seen new tests most likely introduced by this PR. New Test Risks for sha: 677c97e
New tests seen in this PR at sha: 677c97e
|
|
Job Failure Risk Analysis for sha: 677c97e
Risk analysis has seen new tests most likely introduced by this PR. New Test Risks for sha: 677c97e
New tests seen in this PR at sha: 677c97e
|
Contributor
|
@hongkailiu: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Job Failure Risk Analysis for sha: 677c97e
Risk analysis has seen new tests most likely introduced by this PR. New Test Risks for sha: 677c97e
New tests seen in this PR at sha: 677c97e
|
1 similar comment
|
Job Failure Risk Analysis for sha: 677c97e
Risk analysis has seen new tests most likely introduced by this PR. New Test Risks for sha: 677c97e
New tests seen in this PR at sha: 677c97e
|
Member
Author
|
/retest-required |
openshift-merge-bot
bot
merged commit 618d3bd
into
openshift:main
23 of 25 checks passed
hongkailiu
added a commit
to hongkailiu/origin
that referenced
this pull request
Oct 23, 2025
Following up [1], the function `parseClusterOperatorNames` raises up an error if it gets unknown operators which is a result of CVO's producing a malformed message. It leads to a failure associated to component "Cluster Version Operator". [1]. openshift#30269 (comment)
hongkailiu
added a commit
to hongkailiu/origin
that referenced
this pull request
Oct 23, 2025
Following up [1], the function `parseClusterOperatorNames` raises up an error if it gets unknown operators which is a result of CVO's producing a malformed message. It leads to a failure associated to component "Cluster Version Operator". [1]. openshift#30269 (comment)
hongkailiu
added a commit
to hongkailiu/origin
that referenced
this pull request
Oct 23, 2025
Following up [1], the function `parseClusterOperatorNames` raises up an error if it gets unknown operators which is a result of CVO's producing a malformed message. It leads to a failure associated to component "Cluster Version Operator". [1]. openshift#30269 (comment)
openshift-merge-bot bot
added a commit
that referenced
this pull request
Oct 24, 2025
TRT-2373: Revert #30269 "OTA-1626: fail CI if any ClusterOperator takes too long to update"
hongkailiu
added a commit
to hongkailiu/origin
that referenced
this pull request
Oct 27, 2025
…A-1626"" This reverts commit aba036a.
openshift-merge-bot bot
added a commit
that referenced
this pull request
Oct 29, 2025
TRT-2373: Revert "Revert "Merge pull request #30269 from hongkailiu/OTA-1626""
hongkailiu
added a commit
to hongkailiu/origin
that referenced
this pull request
Nov 3, 2025
Following up [1], the function `parseClusterOperatorNames` raises up an error if it gets unknown operators which is a result of CVO's producing a malformed message. It leads to a failure associated to component "Cluster Version Operator". [1]. openshift#30269 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new test case for Cluster Version Operator checks if
clusterversionreports
Failing=Unknownand use it as the indicator of long ClusterOperatorversion update in a cluster upgrade.
The test adds the failure test cases for the component to which the
cluster operator belongs if it spots
Failing=Unknown. The COs areparsed from the Contition's message as there is no API exposing them.