-
Notifications
You must be signed in to change notification settings - Fork 4.8k
OCPEDGE-1485: Add initial version of etcd kill and recovery test #30320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
OCPEDGE-1485: Add initial version of etcd kill and recovery test #30320
Conversation
|
Skipping CI for Draft Pull Request. |
|
@fonta-rh: This pull request references OCPEDGE-1485 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@fonta-rh: This pull request references OCPEDGE-1485 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Job Failure Risk Analysis for sha: 51df2c4
|
51df2c4 to
cf634ab
Compare
|
@fonta-rh: This pull request references OCPEDGE-1485 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@fonta-rh: This pull request references OCPEDGE-1485 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
clobrano
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test is logically correct for me. I just left a couple of notes.
|
Just a few notes from me. Otherwise looking good! |
Add Serial tag Remove unnecessary etcd kill methods
clobrano
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a couple of comments
clobrano
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
Giving time to @jaypoulz to complete his review /hold |
|
@fonta-rh: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: clobrano, fonta-rh, jaypoulz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
Add etcd process crash recovery test for TNF clusters
Add test to validate Two Node with Fencing (TNF) cluster recovery after etcd process crashes.
The test kills the etcd process/container on one node and validates that Pacemaker automatically detects the failure and restarts etcd, with the cluster returning to a healthy state (both nodes as started voting members).
Test approach:
GinkgoRecover()to properly handle validation panics withinEventuallyretry logicRelated: OCPBUGS-59238 (etcd process crash recovery issue in TNF clusters)
NOTE: This test doesn't work on an un-patched, un-reconfigured TNF cluster at the moment. It's set to be skipped until that point