OCPBUGS-56281: gatewayapicontroller: Use dynamic client for OLM #30397
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
|
/test ci/prow/e2e-gcp-ovn |
|
@Miciah: The specified target(s) for The following commands are available to trigger optional jobs: Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test e2e-gcp-ovn |
Miciah
force-pushed
the
gatewayapicontroller-use-dynamic-client-for-olm
branch
from
b2f6c01 to
a35d2a2
Compare
|
e2e-gcp-ovn failed with |
|
/test e2e-gcp-ovn |
Miciah
force-pushed
the
gatewayapicontroller-use-dynamic-client-for-olm
branch
from
a35d2a2 to
e099cf6
Compare
|
https://github.com/openshift/origin/compare/a35d2a29f8b7e2768f5d544230d7ae8a5fbd0f1c..e099cf6ba75e5ed81f6120f351535e7f1df47c7d is a more sophisticated attempt at getting the unstructured conversion of the Operator CR status right. This push also adds logging for deletions as well as deletion of the Operator CR itself at the end of the cleanup. /test e2e-gcp-ovn |
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/retest-required |
1 similar comment
|
/retest-required |
| g.By("Deleting the OSSM Operator resources") | ||
|
|
||
| operator, err := operatorsv1.NewForConfigOrDie(oc.AsAdmin().UserConfig()).Operators().Get(context.Background(), serviceMeshOperatorName, metav1.GetOptions{}) | ||
| client, err := dynamic.NewForConfig(oc.AdminConfig()) |
There was a problem hiding this comment.
nit: the client already exists in oc.KubeFramework().DynamicClient (see line 186 below)
There was a problem hiding this comment.
Thanks! https://github.com/openshift/origin/compare/e099cf6ba75e5ed81f6120f351535e7f1df47c7d..c5d2f04bbcbba4ce94abaf156d7df7673d013372 changes this logic to use the existing oc.KubeFramework().DynamicClient instead of creating a new client.
Instead of using the OperatorsV1 client from the github.com/operator-framework/operator-lifecycle-manager package, use the dynamic client, and drop the import for this package. Vendoring this package necessitated adding a replace stanza for openshift/api in go.mod; this stanza can now be dropped. The replace stanza was causing problems to people who wanted to import openshift/origin to use the OpenShift Tests Extensions framework. Follow-up to commit 407d63b. * go.mod: Drop github.com/operator-framework/operator-lifecycle-manager, and drop the replace rule for openshift/api. * go.sum: Regenerate. * test/extended/router/gatewayapicontroller.go: Use the dynamic client. * vendor/*: Regenerate.
Log each deleted object during post-test cleanup. * test/extended/router/gatewayapicontroller.go: Add logging.
Delete the Operator CR for the Service Mesh operator during post-test cleanup. * test/extended/router/gatewayapicontroller.go: Add delete command.
Miciah
force-pushed
the
gatewayapicontroller-use-dynamic-client-for-olm
branch
from
e099cf6 to
c5d2f04
Compare
|
/lgtm |
|
/override ci/prow/e2e-aws-ovn-microshift These jobs are failing due to the rebase of o/k and need manual action from the Microshift team. We're temporarily making them optional here until that's fixed: openshift/release#70458 |
openshift-ci
bot
added
the
approved
|
@bertinatto: Overrode contexts on behalf of bertinatto: ci/prow/e2e-aws-ovn-microshift, ci/prow/e2e-aws-ovn-microshift-serial In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bertinatto, Miciah, tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required |
1 similar comment
|
/retest-required |
|
/test e2e-aws-csi |
|
Job Failure Risk Analysis for sha: c5d2f04
|
|
ci/prow/images failed with the following error: I expect this is a transient infrastructure error. /test images |
Miciah
changed the title
openshift-ci-robot
added
jira/severity-critical
|
@Miciah: This pull request references Jira Issue OCPBUGS-56281, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@Miciah: This pull request references Jira Issue OCPBUGS-56281, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest-required |
|
/retest-required |
|
/verified by ci/prow/e2e-gcp-ovn
|
openshift-ci-robot
added
the
verified
|
@bertinatto: This PR has been marked as verified by In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/override ci/prow/e2e-aws-ovn-serial-1of2 The test is not part of the serial test suite. Overriding to unblock merges. |
|
@bertinatto: Overrode contexts on behalf of bertinatto: ci/prow/e2e-aws-ovn-serial-1of2 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
openshift-merge-bot
bot
merged commit 2bc51b3
into
openshift:main
|
@Miciah: Jira Issue Verification Checks: Jira Issue OCPBUGS-56281 Jira Issue OCPBUGS-56281 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@Miciah: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Fix included in accepted release 4.21.0-0.nightly-2025-10-22-123727 |
6 participants
Instead of using the OperatorsV1 client from the github.com/operator-framework/operator-lifecycle-manager package, use the dynamic client, and drop the import for this package. Vendoring this package necessitated adding a replace stanza for openshift/api in go.mod; this stanza can now be dropped.
The replace stanza was causing problems to people who wanted to import openshift/origin to use the OpenShift Tests Extensions framework.
Follow-up to 407d63b.