Skip to content

[release-4.20] OCPBUGS-63335: Check more operatorsProgressing #30400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
openshift-cherrypick-robot wants to merge 1 commit into
base: release-4.20
Choose a base branch
from
Open

[release-4.20] OCPBUGS-63335: Check more operatorsProgressing #30400

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 16 additions & 15 deletions pkg/monitortests/network/legacynetworkmonitortests/networking.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,14 +73,14 @@ func testPodSandboxCreation(events monitorapi.Intervals, clientConfig *rest.Conf

failures := []string{}
flakes := []string{}
networkOperatorProgressing := events.Filter(func(ev monitorapi.Interval) bool {
// Any disruption during cluster's upgrading, such as node restarts, CNI/OVN/DNS outages, or API lookups used by the CNI, can result in a FailedCreatePodSandBox error.
operatorsProgressing := events.Filter(func(ev monitorapi.Interval) bool {
annotations := ev.Message.Annotations
if annotations[monitorapi.AnnotationCondition] != string(configv1.OperatorProgressing) {
return false
}
isNetwork := ev.Locator.Keys[monitorapi.LocatorClusterOperatorKey] == "network"
isMCO := ev.Locator.Keys[monitorapi.LocatorClusterOperatorKey] == "machine-config"
if isNetwork || isMCO {
switch ev.Locator.Keys[monitorapi.LocatorClusterOperatorKey] {
case "network", "machine-config", "dns", "kube-apiserver", "etcd":
return true
}
return false
Expand Down Expand Up @@ -183,22 +183,23 @@ func testPodSandboxCreation(events monitorapi.Intervals, clientConfig *rest.Conf

partialLocator := monitorapi.NonUniquePodLocatorFrom(event.Locator)
if deletionTime := getPodDeletionTime(eventsForPods[partialLocator], event.Locator); deletionTime == nil {
// mark sandboxes errors as flakes if networking is being updated
match := -1
for i := range networkOperatorProgressing {
matchesFrom := event.From.After(networkOperatorProgressing[i].From)
matchesTo := event.To.Before(networkOperatorProgressing[i].To)
if matchesFrom && matchesTo {
match = i
var progressingOperatorName string
for _, operatorProgressingInterval := range operatorsProgressing {
if event.From.After(operatorProgressingInterval.From) &&
event.To.Before(operatorProgressingInterval.To) {
progressingOperatorName = operatorProgressingInterval.Locator.Keys[monitorapi.LocatorClusterOperatorKey]
break
}
}
if match != -1 {
flakes = append(flakes, fmt.Sprintf("%v - never deleted - network rollout - %v", event.Locator.OldLocator(), event.Message.OldMessage()))
if len(progressingOperatorName) > 0 {
flakes = append(flakes, fmt.Sprintf(
"%v - never deleted - operator:%s was progressing which may cause pod sandbox creation errors - %v",
event.Locator.OldLocator(), progressingOperatorName, event.Message.OldMessage()))
} else {
failures = append(failures, fmt.Sprintf("%v - never deleted - %v", event.Locator.OldLocator(), event.Message.OldMessage()))
failures = append(failures, fmt.Sprintf(
"%v - never deleted - operator:%s was progressing which may cause pod sandbox creation errors - %v",
event.Locator.OldLocator(), progressingOperatorName, event.Message.OldMessage()))
}

} else {
timeBetweenDeleteAndFailure := event.From.Sub(*deletionTime)
switch {
Expand Down