Skip to content

OCPEDGE-1788: TNF add etcd cold boot recovery tests from graceful node shutdown #30519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
clobrano wants to merge 3 commits into
base: main
Choose a base branch
from
Open

OCPEDGE-1788: TNF add etcd cold boot recovery tests from graceful node shutdown #30519

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
129b681
feat: add VirshShutdownVM helper for graceful VM shutdown
clobrano Nov 24, 2025
48ed091
feat: add three new etcd cold boot recovery tests
clobrano Nov 24, 2025
d810c36
Add skipped tag with known issue reference
clobrano Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
feat: add VirshShutdownVM helper for graceful VM shutdown
  • Loading branch information
@clobrano
clobrano committed Dec 1, 2025
commit 129b681f08dd2427b5def3397d98c571bee2026b
14 changes: 14 additions & 0 deletions test/extended/two_node/utils/services/libvirt.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,20 @@ func VirshGetVMUUID(vmName string, sshConfig *core.SSHConfig, knownHostsPath str
return uuid, err
}

// VirshShutdownVM gracefully shuts down a running VM (allows guest OS to shutdown cleanly).
//
// err := VirshShutdownVM("master-0", sshConfig, knownHostsPath)
func VirshShutdownVM(vmName string, sshConfig *core.SSHConfig, knownHostsPath string) error {
klog.V(2).Infof("VirshShutdownVM: Gracefully shutting down VM '%s'", vmName)
_, err := VirshCommand(fmt.Sprintf("shutdown %s", vmName), sshConfig, knownHostsPath)
if err != nil {
klog.ErrorS(err, "VirshShutdownVM failed", "vm", vmName)
} else {
klog.V(2).Infof("VirshShutdownVM: Successfully initiated shutdown for VM '%s'", vmName)
}
return err
}

// VirshUndefineVM undefines a VM (removes libvirt config, not disk images).
//
// err := VirshUndefineVM("master-0", sshConfig, knownHostsPath)
Expand Down