TRT-2439: Revert "TLS 1.3 / Modern profile tests" #30533
Conversation
This reverts commit 66bb721.
|
Pipeline controller notification For optional jobs, comment This repository is configured in: automatic mode |
openshift-ci-robot
added
the
jira/valid-reference
|
@neisw: This pull request references TRT-2439 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
approved
|
/payload-job periodic-ci-openshift-release-master-nightly-4.21-e2e-metal-ipi-ovn-bm |
|
@neisw: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/c3b9d730-ca31-11f0-89ff-3c5c590f860d-0 |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: neisw, wangke19 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test e2e-metal-ipi-ovn-ipv6 |
|
/pipeline required |
|
Scheduling required tests: |
|
/verified by payload-job |
openshift-ci-robot
added
the
verified
|
@neisw: This PR has been marked as verified by In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/override ci/prow/e2e-aws-csi |
|
@neisw: Overrode contexts on behalf of neisw: ci/prow/e2e-aws-csi, ci/prow/e2e-aws-ovn-fips, ci/prow/e2e-aws-ovn-microshift, ci/prow/e2e-aws-ovn-microshift-serial, ci/prow/e2e-aws-ovn-serial-1of2, ci/prow/e2e-aws-ovn-serial-2of2, ci/prow/e2e-gcp-csi, ci/prow/e2e-gcp-ovn, ci/prow/e2e-gcp-ovn-upgrade, ci/prow/e2e-metal-ipi-ovn-ipv6, ci/prow/e2e-vsphere-ovn, ci/prow/e2e-vsphere-ovn-upi In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@neisw: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This commit fixes two bugs in the TLS test that were causing failures:
1. Variable shadowing bug (line 145):
- Changed `err := conn.Close()` to `closeErr := conn.Close()`
- The original code shadowed the outer `err` variable, making the
test logic confusing and error-prone
- Now the test correctly checks the Dial error, not the Close error
2. Missing URL prefix stripping in cipher test (line 168-170):
- Added `host := strings.TrimPrefix(oc.AdminConfig().Host, "https://")`
- The cipher test was trying to dial with "https://..." prefix
- tls.Dial expects "host:port" format, not a URL
3. Improved error handling in cipher test (line 172):
- Properly capture and use closeErr instead of calling conn.Close()
inline in the error message
These fixes address the test failures reported in:
periodic-ci-openshift-release-master-nightly-4.21-e2e-metal-ipi-ovn-bm
Related: PR openshift#30533 (the revert), PR openshift#29611 (original implementation)
This commit fixes two bugs in the TLS test that were causing failures:
1. Variable shadowing bug (line 145):
- Changed `err := conn.Close()` to `closeErr := conn.Close()`
- The original code shadowed the outer `err` variable, making the
test logic confusing and error-prone
- Now the test correctly checks the Dial error, not the Close error
2. Missing URL prefix stripping in cipher test (line 168-170):
- Added `host := strings.TrimPrefix(oc.AdminConfig().Host, "https://")`
- The cipher test was trying to dial with "https://..." prefix
- tls.Dial expects "host:port" format, not a URL
3. Improved error handling in cipher test (line 172):
- Properly capture and use closeErr instead of calling conn.Close()
inline in the error message
These fixes address the test failures reported in:
periodic-ci-openshift-release-master-nightly-4.21-e2e-metal-ipi-ovn-bm
Related: PR openshift#30533 (the revert), PR openshift#29611 (original implementation)
This commit fixes two bugs in the TLS test that were causing failures:
1. Variable shadowing bug (line 145):
- Changed `err := conn.Close()` to `closeErr := conn.Close()`
- The original code shadowed the outer `err` variable, making the
test logic confusing and error-prone
- Now the test correctly checks the Dial error, not the Close error
2. Missing URL prefix stripping in cipher test (line 168-170):
- Added `host := strings.TrimPrefix(oc.AdminConfig().Host, "https://")`
- The cipher test was trying to dial with "https://..." prefix
- tls.Dial expects "host:port" format, not a URL
3. Improved error handling in cipher test (line 172):
- Properly capture and use closeErr instead of calling conn.Close()
inline in the error message
These fixes address the test failures reported in:
periodic-ci-openshift-release-master-nightly-4.21-e2e-metal-ipi-ovn-bm
Related: PR openshift#30533 (the revert), PR openshift#29611 (original implementation)
3 participants
Reverts #29611
Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.
Payload failures due to
[sig-api-machinery][Feature:APIServer] TestTLSDefaults [Suite:openshift/conformance/parallel]To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem:
CC: @jacobsee