[WIP]Fix/tls13 tests bm #30535
[WIP]Fix/tls13 tests bm #30535
Conversation
Adds tests to core services for ensuring that they are serving TLS versions in line with the currently selected TLS profile in the cluster config.
The TestTLSDefaults test was failing because of a variable shadowing issue introduced in commit b623c83. The code was declaring a new 'err' variable when closing the connection, which shadowed the outer 'err' variable from the tls.Dial() call. This caused the test to check the wrong error value when determining if the TLS connection succeeded, leading to false test failures with the message: "Expected success true, got false with TLS version VersionTLS12 dialing master" The fix renames the close error variable to 'closeErr' to avoid shadowing the dial error, ensuring the test correctly evaluates whether the TLS connection succeeded. Fixes: periodic-ci-openshift-release-master-nightly-4.21-e2e-metal-ipi-ovn-bm 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
|
Pipeline controller notification For optional jobs, comment This repository is configured in: automatic mode |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: wangke19 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/close |
|
@wangke19: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
3 participants
No description provided.