Skip to content

CNTRLPLANE-1437: add monitor test for checking default service account in pods (static test name) #30561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ehearne-redhat wants to merge 4 commits into
base: main
Choose a base branch
from
Open

CNTRLPLANE-1437: add monitor test for checking default service account in pods (static test name) #30561

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f984c9b
add revert monitor tests
ehearne-redhat Dec 3, 2025
50d5f8a
ensure static test name completely
ehearne-redhat Dec 3, 2025
3f22edf
bring back ns level testing + exempt dynamic ns names
ehearne-redhat Dec 3, 2025
7073eae
remove openshift-must-gather- ns exception + add comments explaining …
ehearne-redhat Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
remove openshift-must-gather- ns exception + add comments explaining … 
…core openshift checks
  • Loading branch information
@ehearne-redhat
ehearne-redhat committed Dec 5, 2025
commit 7073eae36726388c019e67c32ad18a9f8f94833c
11 changes: 7 additions & 4 deletions pkg/monitortests/authentication/nodefaultserviceaccountoperatortests/monitortest.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@ var exceptions = []func(pod corev1.Pod) (string, bool){
exceptionWithJira("default/verify-all-openshiftcertifiedoperators-", "https://issues.redhat.com/browse/OCPBUGS-65634"),
exceptionWithJira("default/verify-all-openshiftredhatoperators-", "https://issues.redhat.com/browse/OCPBUGS-65634"),
exceptionWithJira("openshift-cluster-version/version-", "https://issues.redhat.com/browse/OCPBUGS-65621"),
exceptionWithJira("openshift-must-gather/must-gather-", "https://issues.redhat.com/browse/OCPBUGS-65635"), // keep as default service account required for this component.
exceptionWithJira("kube-system/konnectivity-agent-", "https://issues.redhat.com/browse/OCPBUGS-65636"),
exceptionWithJira("openshift-multus/multus-additional-cni-plugins-", "https://issues.redhat.com/browse/OCPBUGS-65631"),
exceptionWithJira("openshift-multus/cni-sysctl-allowlist-ds-", "https://issues.redhat.com/browse/OCPBUGS-65631"),
Expand Down Expand Up @@ -112,8 +111,6 @@ func (n *noDefaultServiceAccountChecker) generateTestCases(ctx context.Context,
continue
}
failureList = append(failureList, failure)

exceptionList = append(exceptionList, failure)
}

aggregatedList := append(failureList, exceptionList...)
Expand Down Expand Up @@ -168,9 +165,15 @@ func (n *noDefaultServiceAccountChecker) CollectData(ctx context.Context, storag
}
junits := []*junitapi.JUnitTestCase{}
for _, ns := range namespaces.Items {
if ns.GenerateName != "" { // dynamically generated namespace names are exempt from checks
// Any namespaces with non-empty GenerateName attributes are dynamic namespace names.
// These are exempt from testing as they cause CI Failures due to non static test naming.
// Only known dynamic namespace is openshift-must-gather- which is exempt as it is not
// core OpenShift.
if ns.GenerateName != "" {
continue
}
// We are only checking openshift- , kube- , and default namespaces as these are the namespaces which contain
// core OpenShift components.
if !strings.HasPrefix(ns.Name, "openshift-") && !strings.HasPrefix(ns.Name, "kube-") && ns.Name != "default" {
continue
}
Expand Down