Add e2e-metal-assisted to installer and cluster-version-operator #13384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wking so CVO can be tested in assisted flow |
Add an optional e2e-metal-assisted job for installer and cluster-version-operator Generated by manually changing `ci-operator/config/...`, running: ``` $ make update ``` and tuning the configurable always_run and optional fields.
YuviGold
force-pushed
the
e2e-metal-assisted-to-installer-and-cvo
branch
from
540ef8a to
f0d68be
Compare
Contributor
Author
|
/retest |
Member
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sdodson, vrutkovs, YuviGold The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Contributor
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Contributor
|
@YuviGold: Updated the following 3 configmaps:
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This was referenced Nov 11, 2020
wking
added a commit
to wking/openshift-release
that referenced
this pull request
Dec 8, 2020
… base_images for 4.6 and later Per Justin, these are now handled implicitly by ci-operator, so removing them reduces the chance that CI builds diverge from ART builds (see also [1]). dev-scripts is from f0d68be (Add e2e-metal-assisted to installer and cluster-version-operator, 2020-11-04, openshift#13384), and is implicitly passed through and then consumed by the baremetalds-packet-setup step and similar, so we need to keep that for 4.7 and later (where we have an e2e-metal-assisted entry in tests). assisted-test-infra is from c11d67d (cluster-version-operator uses openshift-kni/assisted-test, 2020-12-06, openshift#14119), and is consumed by baremetalds-assisted-setup. [1]: https://github.com/openshift/enhancements/blob/master/enhancements/art/flexibly-enforcing-product-build-constraints-in-ci.md
wking
added a commit
to wking/openshift-release
that referenced
this pull request
Jan 24, 2022
…-assisted presubmits These are descended from f0d68be (Add e2e-metal-assisted to installer and cluster-version-operator, 2020-11-04, openshift#13384), where they were intended to make it easy for folks to evaluate in-flight CVO pull requests vs. assisted-installer CI. However, with the recent '/payload ...' test support [1], we can maintain the job configuration for the release-controller periodics, and run them as needed on component pull requests, without having to maintain per-component presubmit configuration. This commit drops the per-component presubmit configuration to reduce future maintenance work. [1]: https://docs.ci.openshift.org/docs/release-oversight/payload-testing/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an optional e2e-metal-assisted job for installer and
cluster-version-operator
Generated by manually changing
ci-operator/config/..., running:and tuning the configurable always_run and optional fields.