Skip to content

Make gcp and aws disruptive mandatory for origin and etcd operator #14312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
marun wants to merge 2 commits into from
Closed

Make gcp and aws disruptive mandatory for origin and etcd operator #14312

marun wants to merge 2 commits into from

Conversation

@marun
Copy link
Contributor

@marun marun commented Dec 14, 2020 •
edited
Loading

Not being mandatory allows the jobs to rot, and the functionality they are testing is essential to the health of the product.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 14, 2020
@hexfusion
Copy link
Contributor

hexfusion commented Dec 14, 2020

/approve

@marun
Copy link
Contributor Author

marun commented Dec 15, 2020

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 15, 2020
@marun marun changed the title WIP Make e2e-aws-disruptive mandatory for origin and etcd operator Make e2e-aws-disruptive mandatory for origin and etcd operator Dec 15, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 15, 2020
@marun
Copy link
Contributor Author

marun commented Dec 16, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 16, 2020
@hexfusion
Copy link
Contributor

hexfusion commented Dec 16, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 16, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 16, 2020

New changes are detected. LGTM label has been removed.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Dec 16, 2020
petr-muller
petr-muller reviewed Dec 16, 2020
View reviewed changes
core-services/template-deprecation/_allowlist.yaml Outdated
Copy link
Member

@petr-muller petr-muller Dec 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add these under DPTP-1775 above (git checkout HEAD^^^ core-services/template-deprecation/_allowlist.yaml; make template-allowlist BLOCKER=DPTP-1775 should do the trick, too)

Copy link
Contributor Author

@marun marun Dec 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@hexfusion
Copy link
Contributor

hexfusion commented Dec 16, 2020

@marun looks like GCP rehearse failed.

https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_release/14312/rehearse-14312-pull-ci-openshift-cluster-etcd-operator-master-e2e-gcp-disruptive/1339061461762183168

@hexfusion
Copy link
Contributor

hexfusion commented Dec 16, 2020

/retest

@marun
Copy link
Contributor Author

marun commented Dec 16, 2020

@marun looks like GCP rehearse failed.

https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_release/14312/rehearse-14312-pull-ci-openshift-cluster-etcd-operator-master-e2e-gcp-disruptive/1339061461762183168

The disruptive job is not yet passing on gcp. That's why it's being added optional and on-demand rather than mandatory.

@marun
Copy link
Contributor Author

marun commented Dec 16, 2020 •
edited
Loading

Waiting for openshift/origin#25774 to merge

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 16, 2020
@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Dec 17, 2020

@marun: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/rehearse/openshift/cluster-etcd-operator/master/e2e-gcp-disruptive 2fc29fc187d7e927091215c54007a72a086f02f4 link /test pj-rehearse
ci/rehearse/openshift/cluster-etcd-operator/master/e2e-gcp 2fc29fc187d7e927091215c54007a72a086f02f4 link /test pj-rehearse
ci/rehearse/openshift/cluster-etcd-operator/master/e2e-aws-disruptive 2fc29fc187d7e927091215c54007a72a086f02f4 link /test pj-rehearse
ci/prow/pj-rehearse 2fc29fc187d7e927091215c54007a72a086f02f4 link /test pj-rehearse

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@petr-muller
Copy link
Member

petr-muller commented Dec 22, 2020

/approve

(allowlist changes)

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 22, 2020
@marun
Copy link
Contributor Author

marun commented Feb 9, 2021

This PR is still on hold pending evidence of the stability of the jobs in question.

marun and others added 2 commits February 15, 2021 10:37
@marun
Update gcp and aws disruptive to be mandatory for origin master
5f7259a 
Not being mandatory allows the jobs to rot, and the functionality they
test is essential to the health of the product.
Update gcp and aws disruptive to be mandatory for ceo master
01fa2a2 
Not being mandatory allows the jobs to rot, and the functionality they
are testing is essential to the health of the product.
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 15, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hexfusion, marun, petr-muller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@marun marun changed the title Make e2e-aws-disruptive mandatory for origin and etcd operator Make gcp and aws disruptive mandatory for origin and etcd operator Feb 15, 2021
@marun marun closed this Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

@hexfusion hexfusion Awaiting requested review from hexfusion

@ironcladlou ironcladlou Awaiting requested review from ironcladlou

@retroflexer retroflexer Awaiting requested review from retroflexer

1 more reviewer

@petr-muller petr-muller petr-muller left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@hexfusion hexfusion

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@marun @hexfusion @openshift-ci-robot @openshift-merge-robot @petr-muller